You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/03/23 12:29:30 UTC
Review Request 45209: Made sure all Python modules are installed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45209/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-5010
https://issues.apache.org/jira/browse/MESOS-5010
Repository: mesos
Description
-------
The way our build sets up PYTHONPATH it appears to pip as if the
mesos.cli package is already installed when it is only present in some
directory in PYTHONPATH, but not in the installation target location.
pip subsequently skips mesos.cli leading to a broken install where
files required by e.g., mesos-ps are not installed.
Explicitly ignoring installed packages lets us install mesos.cli.
This appears to be due to some change in behavior first occurring with
pip-6.0.1.
Diffs
-----
src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c
Diff: https://reviews.apache.org/r/45209/diff/
Testing
-------
Thanks,
Benjamin Bannier
Re: Review Request 45209: Made sure all Python modules are installed.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45209/#review125058
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45209]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 23, 2016, 11:29 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45209/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 11:29 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-5010
> https://issues.apache.org/jira/browse/MESOS-5010
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The way our build sets up PYTHONPATH it appears to pip as if the
> mesos.cli package is already installed when it is only present in some
> directory in PYTHONPATH, but not in the installation target location.
> pip subsequently skips mesos.cli leading to a broken install where
> files required by e.g., mesos-ps are not installed.
>
> Explicitly ignoring installed packages lets us install mesos.cli.
>
> This appears to be due to some change in behavior first occurring with
> pip-6.0.1.
>
>
> Diffs
> -----
>
> src/Makefile.am 6552e48eab2708a28dd69adba3ec759cb5aeca4c
>
> Diff: https://reviews.apache.org/r/45209/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Bannier
>
>