You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/01/28 09:13:41 UTC

[GitHub] [sling-org-apache-sling-distribution-core] actinium15 opened a new pull request #34: SLING-9030 less verbose logging for retryable-distribution-failures …

actinium15 opened a new pull request #34: SLING-9030 less verbose logging for retryable-distribution-failures …
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/34
 
 
   …in SimpleDistributionAgentQueueProcessor

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-distribution-core] actinium15 commented on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …

Posted by GitBox <gi...@apache.org>.
actinium15 commented on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/34#issuecomment-579223873
 
 
   >I suggest to simply lower the logging to WARN in general here.
   
   I didn't want to lose the full exception and stack trace, and (for obvious reasons) didn't want to include that in the WARN log.
   
   >I think it is not a good practice though to check for the debug level and then decide between logging on ERROR or WARN level
   
   Would you prefer if I just log the exception additionally if debug is enabled? (as in `if (log.isDebugEnabled()) log.error(e);`). Or are you of the opinion that logging the full exception and trace is of not value at any log level?
   
   \cc: @tmaret

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-distribution-core] tmaret commented on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …

Posted by GitBox <gi...@apache.org>.
tmaret commented on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/34#issuecomment-579218838
 
 
   @actinium15 I share @cschneider view here. Simply logging at WARN level makes sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-distribution-core] actinium15 edited a comment on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …

Posted by GitBox <gi...@apache.org>.
actinium15 edited a comment on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/34#issuecomment-579223873
 
 
   >I suggest to simply lower the logging to WARN in general here.
   
   @cschneider, I didn't want to lose the full exception and stack trace, and (for obvious reasons) didn't want to include that in the WARN log.
   
   >I think it is not a good practice though to check for the debug level and then decide between logging on ERROR or WARN level
   
   Would you prefer if I just log the exception additionally if debug is enabled? (as in `if (log.isDebugEnabled()) log.error(e);`), or are you suggesting `log.debug(e)`? (latter has the chances of being missed if one were to run grep on large logs in production)
   
   Or are you of the opinion that logging the full exception and trace is of not value at any log level?
   
   \cc: @tmaret

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-distribution-core] actinium15 edited a comment on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …

Posted by GitBox <gi...@apache.org>.
actinium15 edited a comment on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/34#issuecomment-579223873
 
 
   >I suggest to simply lower the logging to WARN in general here.
   
   @cschneider, I didn't want to lose the full exception and stack trace, and (for obvious reasons) didn't want to include that in the WARN log.
   
   >I think it is not a good practice though to check for the debug level and then decide between logging on ERROR or WARN level
   
   Would you prefer if I just log the exception additionally if debug is enabled? (as in `if (log.isDebugEnabled()) log.error(e);`). Or are you of the opinion that logging the full exception and trace is of not value at any log level?
   
   \cc: @tmaret

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-distribution-core] tmaret closed pull request #34: SLING-9030 less verbose logging for retryable-distribution-failures …

Posted by GitBox <gi...@apache.org>.
tmaret closed pull request #34: SLING-9030 less verbose logging for retryable-distribution-failures …
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/34
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-distribution-core] cschneider commented on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …

Posted by GitBox <gi...@apache.org>.
cschneider commented on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/34#issuecomment-579221023
 
 
   Why did you close the PR ? I requested to change the PR to reflect logging at WARN level.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [sling-org-apache-sling-distribution-core] cschneider commented on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …

Posted by GitBox <gi...@apache.org>.
cschneider commented on issue #34: SLING-9030 less verbose logging for retryable-distribution-failures …
URL: https://github.com/apache/sling-org-apache-sling-distribution-core/pull/34#issuecomment-579241722
 
 
   I think logging the exception only if debug is enabled is good. It is just that I would not change the general log level. So I propose to log on WARN level and in case of debug level add the exception to the log message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services