You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2018/10/01 12:59:36 UTC
[GitHub] spark pull request #22599: [SPARK-25581][SQL] Rename method `benchmark` as `...
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22599
[SPARK-25581][SQL] Rename method `benchmark` as `benchmarkSuite` in `BenchmarkBase`
## What changes were proposed in this pull request?
Rename method `benchmark` in `BenchmarkBase` as `benchmarkSuite`. Also add comment.
Currently the method name `benchmark` is a bit confusing. Also the name is the same as instances of `Benchmark`:
https://github.com/apache/spark/blob/f246813afba16fee4d703f09e6302011b11806f3/sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala#L330-L339
## How was this patch tested?
Unit test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gengliangwang/spark renameBenchmarkSuite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22599.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22599
----
commit 289ee3ec63e0c04fb15f4c8c5a070614c52ae982
Author: Gengliang Wang <ge...@...>
Date: 2018-10-01T12:36:27Z
rename method benchmark as benchmarkSuite
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3604/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `runBenc...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22599
**[Test build #96855 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96855/testReport)** for PR 22599 at commit [`1c15c25`](https://github.com/apache/spark/commit/1c15c25430b5084381c71215e4e2ea1f72f0af7c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `runBenc...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22599
@wangyum @dongjoon-hyun @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `runBenc...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22599
**[Test build #96855 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96855/testReport)** for PR 22599 at commit [`1c15c25`](https://github.com/apache/spark/commit/1c15c25430b5084381c71215e4e2ea1f72f0af7c).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22599
**[Test build #96816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96816/testReport)** for PR 22599 at commit [`289ee3e`](https://github.com/apache/spark/commit/289ee3ec63e0c04fb15f4c8c5a070614c52ae982).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96816/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `runBenc...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96855/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96818/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22599: [SPARK-25581][SQL] Rename method `benchmark` as `...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22599#discussion_r221636295
--- Diff: core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala ---
@@ -25,7 +25,10 @@ import java.io.{File, FileOutputStream, OutputStream}
abstract class BenchmarkBase {
var output: Option[OutputStream] = None
- def benchmark(): Unit
+ /**
+ * Main process of the whole benchmark.
+ */
+ def benchmarkSuite(): Unit
--- End diff --
Well it means a collection of benchmarks. Just like `TestSuite` is a collection of test cases.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `runBenc...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3628/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `runBenc...
Posted by wangyum <gi...@git.apache.org>.
Github user wangyum commented on the issue:
https://github.com/apache/spark/pull/22599
Thanks @gengliangwang I agree with you. It’s a good change.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `runBenc...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/22599
Discuss with @cloud-fan offline. Rename method `benchmark` as `runBenchmarkSuite`. Also add comment to guide developers to use `runBenchmark` for each scenario in implementations.
@dongjoon-hyun @wangyum Is this OK to you?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22599: [SPARK-25581][SQL] Rename method `benchmark` as `...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22599#discussion_r221637241
--- Diff: core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala ---
@@ -25,7 +25,10 @@ import java.io.{File, FileOutputStream, OutputStream}
abstract class BenchmarkBase {
var output: Option[OutputStream] = None
- def benchmark(): Unit
+ /**
+ * Main process of the whole benchmark.
+ */
+ def benchmarkSuite(): Unit
--- End diff --
For the word `suite`, it doesn't have to be about testing.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22599: [SPARK-25581][SQL] Rename method `benchmark` as `...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22599
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22599
**[Test build #96818 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96818/testReport)** for PR 22599 at commit [`78e48ea`](https://github.com/apache/spark/commit/78e48eac782fe0eab42a84133699dc13c0aae2aa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22599: [SPARK-25581][SQL] Rename method `benchmark` as `...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/22599#discussion_r221634009
--- Diff: core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala ---
@@ -25,7 +25,10 @@ import java.io.{File, FileOutputStream, OutputStream}
abstract class BenchmarkBase {
var output: Option[OutputStream] = None
- def benchmark(): Unit
+ /**
+ * Main process of the whole benchmark.
+ */
+ def benchmarkSuite(): Unit
--- End diff --
I got the idea of this PR. But, for me, `benchmarkSuite` looks like a test suite again. Isn't it confusing in another way.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/3602/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22599
**[Test build #96816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96816/testReport)** for PR 22599 at commit [`289ee3e`](https://github.com/apache/spark/commit/289ee3ec63e0c04fb15f4c8c5a070614c52ae982).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `runBenc...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22599
**[Test build #96818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96818/testReport)** for PR 22599 at commit [`78e48ea`](https://github.com/apache/spark/commit/78e48eac782fe0eab42a84133699dc13c0aae2aa).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22599: [SPARK-25581][SQL] Rename method `benchmark` as `benchma...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22599
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org