You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/04/09 17:23:05 UTC

[GitHub] rhtyd commented on a change in pull request #2555: Remove 'md5Hashed' variable from Javascript.

rhtyd commented on a change in pull request #2555: Remove 'md5Hashed' variable from Javascript.
URL: https://github.com/apache/cloudstack/pull/2555#discussion_r180169076
 
 

 ##########
 File path: ui/scripts/sharedFunctions.js
 ##########
 @@ -45,10 +45,6 @@ var ERROR_INTERNET_NAME_NOT_RESOLVED = 12007;
 var ERROR_INTERNET_CANNOT_CONNECT = 12029;
 var ERROR_VMOPS_ACCOUNT_ERROR = 531;
 
-// Default password is MD5 hashed.  Set the following variable to false to disable this.
-var md5Hashed = false;
 
 Review comment:
   @rafaelweingartner while this PR LGTM, we may need to discuss with user/dev@ as this variable may be set by a UI plugin that is not opensource or with the upstream tree? Certain parts of the code may exist and appear to be not used at all, but may be used by an external UI/backend plugin.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services