You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@infra.apache.org by "Jukka Zitting (JIRA)" <ji...@apache.org> on 2012/07/14 11:58:33 UTC
[jira] [Created] (INFRA-5049) Better From: line for GitHub pull
request notifications
Jukka Zitting created INFRA-5049:
------------------------------------
Summary: Better From: line for GitHub pull request notifications
Key: INFRA-5049
URL: https://issues.apache.org/jira/browse/INFRA-5049
Project: Infrastructure
Issue Type: Improvement
Security Level: public (Regular issues)
Components: Git
Reporter: Jukka Zitting
Assignee: Jukka Zitting
Currently the GitHub pull request notification messages come from "Git at Apache <gi...@git.apache.org>". It would be nicer if at least the sender name was that of the GitHub user who sent the pull request. We could also set the from address, but that might cause spam filters to catch the messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (INFRA-5049) Better From: line for GitHub pull
request notifications
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting resolved INFRA-5049.
----------------------------------
Resolution: Fixed
Done in revision ace9b7c by changing the from address simply to "$user <gi...@git.apache.org>" where $user is the GitHub username.
I also experimented with requesting the full name of the GitHub user via the GitHub API, but that's quite a bit of extra overhead and would force us to do full MIME header encoding. For now I think having just the GitHub username on the From line is good enough.
> Better From: line for GitHub pull request notifications
> -------------------------------------------------------
>
> Key: INFRA-5049
> URL: https://issues.apache.org/jira/browse/INFRA-5049
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> Currently the GitHub pull request notification messages come from "Git at Apache <gi...@git.apache.org>". It would be nicer if at least the sender name was that of the GitHub user who sent the pull request. We could also set the from address, but that might cause spam filters to catch the messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (INFRA-5049) Better From: line for GitHub pull
request notifications
Posted by "Tony Stevenson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/INFRA-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tony Stevenson closed INFRA-5049.
---------------------------------
> Better From: line for GitHub pull request notifications
> -------------------------------------------------------
>
> Key: INFRA-5049
> URL: https://issues.apache.org/jira/browse/INFRA-5049
> Project: Infrastructure
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: Git
> Reporter: Jukka Zitting
> Assignee: Jukka Zitting
>
> Currently the GitHub pull request notification messages come from "Git at Apache <gi...@git.apache.org>". It would be nicer if at least the sender name was that of the GitHub user who sent the pull request. We could also set the from address, but that might cause spam filters to catch the messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira