[jira] [Commented] (SLING-12495) ConfigurationSerializerWebConsolePlugin: Rework "Remove properties" logic

["Konrad Windszus (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899732#comment-17899732 ] 

Konrad Windszus commented on SLING-12495:
-----------------------------------------

[~cziegeler] Are you sure that metatype default values are evaluated when installing OSGi configurations (https://issues.apache.org/jira/browse/SLING-11864?focusedCommentId=17722092&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17722092)? I thought this is only relevant for the Felix Web UI. I haven't found any references to Metatype API in https://github.com/apache/sling-org-apache-sling-installer-factory-configuration or https://github.com/apache/sling-org-apache-sling-installer-core/. Is the configuration admin somehow considering metatype default values?

> ConfigurationSerializerWebConsolePlugin: Rework "Remove properties" logic
> -------------------------------------------------------------------------
>
>                 Key: SLING-12495
>                 URL: https://issues.apache.org/jira/browse/SLING-12495
>             Project: Sling
>          Issue Type: Bug
>          Components: Installer
>    Affects Versions: Installer Configuration Factory 1.4.4
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> The logic/UI for hiding certain default/inherited properties introduced with SLING-11864 has several flaws:
> # It allows to hide properties coming from different sources individually not considering the order. That potentially leads to wrong configuration because the sources have a strict priority and it may be the case that a custom configuration reverts a value to its default value (which has been overwritten through inherited properties)
> # the wording of the individual checkboxes is hard to understand:
> ## Remove Properties -> Hide Properties
> ## Merged Properties -> Inherited Properties with a link to https://sling.apache.org/documentation/bundles/configuration-installer-factory.html#merging-of-configuration (hide it in case this feature is not enabled)
> # Reevaluate whether hiding properties having the metatype default value makes sense



--
This message was sent by Atlassian Jira
(v8.20.10#820010)