You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2023/02/05 03:06:19 UTC

[GitHub] [shardingsphere] sandynz commented on a diff in pull request #23996: fix integration test document

sandynz commented on code in PR #23996:
URL: https://github.com/apache/shardingsphere/pull/23996#discussion_r1096615016


##########
docs/document/content/test-manual/integration-test/_index.cn.md:
##########
@@ -49,7 +49,7 @@ weight = 1
 
 ## 使用指南
 
-模块路径:`shardingsphere-test/shardingsphere-test-e2e/shardingsphere-test-e2e-test-suite`
+模块路径:`shardingsphere-test/shardingsphere-test-e2e/shardingsphere-test-e2e-suite`

Review Comment:
   Looks the module path doesn't exist. Is it `test/e2e/suite`?



##########
docs/document/content/test-manual/integration-test/_index.cn.md:
##########
@@ -156,14 +156,14 @@ it.cluster.databases=H2,MySQL,Oracle,SQLServer,PostgreSQL
 #### 运行 Docker 模式
 
 ```bash
-./mvnw -B clean install -f shardingsphere-test/shardingsphere-test-e2e/pom.xml -Pit.env.docker -Dit.cluster.adapters=proxy,jdbc -Dit.scenarios=${scenario_name_1,scenario_name_2,scenario_name_n} -Dit.cluster.databases=MySQL
+./mvnw -B clean install -f test/e2e/pom.xml -Pit.env.docker -Dit.cluster.adapters=proxy,jdbc -Dit.scenarios=${scenario_name_1,scenario_name_2,scenario_name_n} -Dit.cluster.databases=MySQL

Review Comment:
   1, Is `-f test/e2e/pom.xml` or `-f test/e2e/suite/pom.xml`?
   
   2, Looks this command is not used to build docker image. Could we refer to `e2e.yml` and verify it?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org