You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/01 16:09:17 UTC

[GitHub] [incubator-shardingsphere] TaoZhiMLND opened a new pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

TaoZhiMLND opened a new pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042
 
 
   Fixes #5041
   
   Changes proposed in this pull request:
   revise doc for making keyGenerateAlgorithm as a spring bean.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

cherrylzhao commented on a change in pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#discussion_r402027158
 
 

 ##########
 File path: docs/document/content/manual/sharding-jdbc/configuration/config-java.cn.md
 ##########
 @@ -296,12 +296,12 @@ ShardingStrategyConfiguration的实现类，用于配置不分片的策略。
 | *名称*             | *数据类型*                    | *说明*                                                                         |
 | ----------------- | ---------------------------- | ------------------------------------------------------------------------------ |
 | column            | String                       | 自增列名称                                                                      |
-| type              | String                       | 自增列值生成器类型，可自定义或选择内置类型：SNOWFLAKE/UUID |
-| props             | Properties                   | 自增列值生成器的相关属性配置                                                      |
+| type              | String                       | 自增列值生成算法类型，可自定义或选择内置类型：SNOWFLAKE/UUID |
 
 Review comment:
   KeyGeneratorConfigration contains KeyGenerateAlgorithm now, should move the modification to yaml and namespace config

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

cherrylzhao commented on a change in pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#discussion_r402027223
 
 

 ##########
 File path: docs/document/content/manual/sharding-jdbc/configuration/config-java.en.md
 ##########
 @@ -290,12 +290,12 @@ The implementation class of `ShardingStrategyConfiguration`, used to configure n
 | *Name* | *DataType* | *Description*                                                |
 | ------ | ---------- | ------------------------------------------------------------ |
 | column | String     | Column name of key generator                                 |
-| type   | String     | Type of key generator, use user-defined ones or built-in ones, e.g. SNOWFLAKE, UUID |
-| props  | Properties | The Property configuration of key generators                 |
+| type   | String     | Type of key generate algorithm, use user-defined ones or built-in ones, e.g. SNOWFLAKE, UUID |
 
 Review comment:
   KeyGeneratorConfigration contains KeyGenerateAlgorithm now, should move the modification to yaml and namespace config

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#issuecomment-607385378
 
 
   ## Pull Request Test Coverage Report for [Build 10781](https://coveralls.io/builds/29785552)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **57.348%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29785552/badge)](https://coveralls.io/builds/29785552) |
   | :-- | --: |
   | Change from base [Build 10779](https://coveralls.io/builds/29768001): |  0.0% |
   | Covered Lines: | 11714 |
   | Relevant Lines: | 20426 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

cherrylzhao commented on a change in pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#discussion_r402028051
 
 

 ##########
 File path: docs/document/content/manual/sharding-jdbc/configuration/config-spring-namespace.cn.md
 ##########
 @@ -551,17 +563,23 @@ weight = 4
 | ----- | ------ | -------------- |
 | id    | 属性    | Spring Bean Id |
 
+#### \<bean id="" class="org.apache.shardingsphere.shardingjdbc.spring.namespace.factorybean.KeyGenerateAlgorithmFactoryBean" />
 
 Review comment:
   \<bean id="xxxx"> is better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#issuecomment-607382967
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=h1) Report
   > Merging [#5042](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/18827875a7ea16a969aaf65774190125a101f74f&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5042   +/-   ##
   =========================================
     Coverage     53.97%   53.97%           
     Complexity      395      395           
   =========================================
     Files          1149     1149           
     Lines         20426    20426           
     Branches       3701     3701           
   =========================================
     Hits          11024    11024           
     Misses         8725     8725           
     Partials        677      677           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=footer). Last update [1882787...a180a0a](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#issuecomment-607385378
 
 
   ## Pull Request Test Coverage Report for [Build 10783](https://coveralls.io/builds/29786921)
   
   * **2** of **2**   **(100.0%)**  changed or added relevant lines in **1** file are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage increased (+**0.002%**) to **57.351%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29786921/badge)](https://coveralls.io/builds/29786921) |
   | :-- | --: |
   | Change from base [Build 10779](https://coveralls.io/builds/29768001): |  0.002% |
   | Covered Lines: | 11715 |
   | Relevant Lines: | 20427 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#issuecomment-607382967
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=h1) Report
   > Merging [#5042](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/18827875a7ea16a969aaf65774190125a101f74f&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5042   +/-   ##
   =========================================
     Coverage     53.97%   53.97%           
     Complexity      395      395           
   =========================================
     Files          1149     1149           
     Lines         20426    20426           
     Branches       3701     3701           
   =========================================
     Hits          11024    11024           
     Misses         8725     8725           
     Partials        677      677           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=footer). Last update [1882787...a180a0a](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

coveralls commented on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#issuecomment-607385378
 
 
   ## Pull Request Test Coverage Report for [Build 10780](https://coveralls.io/builds/29775730)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **57.348%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29775730/badge)](https://coveralls.io/builds/29775730) |
   | :-- | --: |
   | Change from base [Build 10779](https://coveralls.io/builds/29768001): |  0.0% |
   | Covered Lines: | 11714 |
   | Relevant Lines: | 20426 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#issuecomment-607385378
 
 
   ## Pull Request Test Coverage Report for [Build 10782](https://coveralls.io/builds/29785822)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **57.348%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29785822/badge)](https://coveralls.io/builds/29785822) |
   | :-- | --: |
   | Change from base [Build 10779](https://coveralls.io/builds/29768001): |  0.0% |
   | Covered Lines: | 11714 |
   | Relevant Lines: | 20426 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

cherrylzhao commented on a change in pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#discussion_r402028599
 
 

 ##########
 File path: docs/document/content/manual/sharding-jdbc/configuration/config-spring-namespace.en.md
 ##########
 @@ -560,17 +572,23 @@ Namespace: http://shardingsphere.apache.org/schema/shardingsphere/sharding/shard
 | ------ | --------- | -------------- |
 | id     | Attribute | Spring Bean Id |
 
+#### \<bean id="" class="org.apache.shardingsphere.shardingjdbc.spring.namespace.factorybean.KeyGenerateAlgorithmFactoryBean" />
 
 Review comment:
   \<bean id="xxxx"> is better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] TaoZhiMLND closed pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

TaoZhiMLND closed pull request #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#issuecomment-607382967
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=h1) Report
   > Merging [#5042](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/18827875a7ea16a969aaf65774190125a101f74f&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #5042   +/-   ##
   =========================================
     Coverage     53.97%   53.97%           
     Complexity      395      395           
   =========================================
     Files          1149     1149           
     Lines         20426    20426           
     Branches       3701     3701           
   =========================================
     Hits          11024    11024           
     Misses         8725     8725           
     Partials        677      677           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=footer). Last update [1882787...3fb769d](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5042?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.

cherrylzhao commented on issue #5042: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5042#issuecomment-607606647
 
 
   since this PR contains API change, please submit it to docs5.x branch

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services