You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/10/08 08:29:46 UTC
[GitHub] [calcite] xuzifu666 opened a new pull request, #2933: [Minor] Refactor Matcher class with remove removePartialMatch
xuzifu666 opened a new pull request, #2933:
URL: https://github.com/apache/calcite/pull/2933
removePartialMatch is useless in Mather，and avoid be used by other function remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] JiajunBernoulli commented on pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch
Posted by GitBox <gi...@apache.org>.
JiajunBernoulli commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1277060199
It is public method, maybe some uses use it. We should not remove it unless there is a better method for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] bchapuis commented on pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch
Posted by GitBox <gi...@apache.org>.
bchapuis commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272279359
Sorry, I'm not a commiter to Apache Calcite and lack context to form an opinion on this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xuzifu666 commented on pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272282510
@danny0405 Teacher Chan, the api is not used in Calcite, want to refactor it throght remove it for other developers not use the api，thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xuzifu666 commented on pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272282002
@danny0405 Hi, teacher danny, the api is not used in Calcite，and want to remove it to aviod other developers use it.
> Sorry, I'm not a commiter to Apache Calcite and lack context to form an opinion on this change.
get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xuzifu666 commented on pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272265819
@bchapuis have a review please, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xuzifu666 closed pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch
Posted by GitBox <gi...@apache.org>.
xuzifu666 closed pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch
URL: https://github.com/apache/calcite/pull/2933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xuzifu666 commented on pull request #2933: [Minor] Refactor Matcher class with remove removePartialMatch
Posted by GitBox <gi...@apache.org>.
xuzifu666 commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272282070
> Sorry, I'm not a commiter to Apache Calcite and lack context to form an opinion on this change.
get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org