You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by bl...@apache.org on 2020/03/30 16:29:41 UTC
[incubator-iceberg] branch master updated: Fix typos in internal
APIs (#880)
This is an automated email from the ASF dual-hosted git repository.
blue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-iceberg.git
The following commit(s) were added to refs/heads/master by this push:
new 8ade6e3 Fix typos in internal APIs (#880)
8ade6e3 is described below
commit 8ade6e38a4baebf305f82961ddbee8fa66f5b31f
Author: jun-he <ju...@users.noreply.github.com>
AuthorDate: Mon Mar 30 09:29:35 2020 -0700
Fix typos in internal APIs (#880)
---
api/src/main/java/org/apache/iceberg/types/TypeUtil.java | 2 +-
api/src/test/java/org/apache/iceberg/transforms/TestBucketing.java | 2 +-
.../test/java/org/apache/iceberg/transforms/TestTruncatesResiduals.java | 2 +-
api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java | 2 +-
core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java | 2 +-
core/src/main/java/org/apache/iceberg/avro/ValueWriters.java | 2 +-
parquet/src/main/java/org/apache/iceberg/parquet/ParquetAvro.java | 2 +-
.../src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java | 2 +-
parquet/src/main/java/org/apache/iceberg/parquet/TypeToMessageType.java | 2 +-
.../main/java/org/apache/iceberg/spark/data/SparkParquetWriters.java | 2 +-
.../src/main/java/org/apache/iceberg/spark/data/SparkValueWriters.java | 2 +-
11 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/api/src/main/java/org/apache/iceberg/types/TypeUtil.java b/api/src/main/java/org/apache/iceberg/types/TypeUtil.java
index 009cf42..82c23f1 100644
--- a/api/src/main/java/org/apache/iceberg/types/TypeUtil.java
+++ b/api/src/main/java/org/apache/iceberg/types/TypeUtil.java
@@ -391,7 +391,7 @@ public class TypeUtil {
return MAX_PRECISION[numBytes];
}
- public static int decimalRequriedBytes(int precision) {
+ public static int decimalRequiredBytes(int precision) {
Preconditions.checkArgument(precision >= 0 && precision < 40,
"Unsupported decimal precision: %s", precision);
return REQUIRED_LENGTH[precision];
diff --git a/api/src/test/java/org/apache/iceberg/transforms/TestBucketing.java b/api/src/test/java/org/apache/iceberg/transforms/TestBucketing.java
index 311fff4..868d6be 100644
--- a/api/src/test/java/org/apache/iceberg/transforms/TestBucketing.java
+++ b/api/src/test/java/org/apache/iceberg/transforms/TestBucketing.java
@@ -42,7 +42,7 @@ public class TestBucketing {
private static Constructor<UUID> uuidBytesConstructor;
@BeforeClass
- public static void getUUIDConstrutor() {
+ public static void getUUIDConstructor() {
try {
uuidBytesConstructor = UUID.class.getDeclaredConstructor(byte[].class);
uuidBytesConstructor.setAccessible(true);
diff --git a/api/src/test/java/org/apache/iceberg/transforms/TestTruncatesResiduals.java b/api/src/test/java/org/apache/iceberg/transforms/TestTruncatesResiduals.java
index f2160d5..79b3982 100644
--- a/api/src/test/java/org/apache/iceberg/transforms/TestTruncatesResiduals.java
+++ b/api/src/test/java/org/apache/iceberg/transforms/TestTruncatesResiduals.java
@@ -42,7 +42,7 @@ public class TestTruncatesResiduals {
/**
* Test helper method to compute residual for a given partitionValue against a predicate
- * and assert the resulting residual expression is same as the exprectedOp
+ * and assert the resulting residual expression is same as the expectedOp
*
* @param spec the partition spec
* @param predicate predicate to calculate the residual against
diff --git a/api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java b/api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java
index 14247cb..8cd6a95 100644
--- a/api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java
+++ b/api/src/test/java/org/apache/iceberg/types/TestSerializableTypes.java
@@ -149,7 +149,7 @@ public class TestSerializableTypes {
Types.StringType.get()))
);
- Assert.assertEquals("Schema serialziation should be equal to starting schema",
+ Assert.assertEquals("Schema serialization should be equal to starting schema",
schema.asStruct(), TestHelpers.roundTripSerialize(schema).asStruct());
}
diff --git a/core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java b/core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java
index 70ee423..f358684 100644
--- a/core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java
+++ b/core/src/main/java/org/apache/iceberg/avro/TypeToSchema.java
@@ -221,7 +221,7 @@ class TypeToSchema extends TypeUtil.SchemaVisitor<Schema> {
primitiveSchema = LogicalTypes.decimal(decimal.precision(), decimal.scale())
.addToSchema(Schema.createFixed(
"decimal_" + decimal.precision() + "_" + decimal.scale(),
- null, null, TypeUtil.decimalRequriedBytes(decimal.precision())));
+ null, null, TypeUtil.decimalRequiredBytes(decimal.precision())));
break;
default:
throw new UnsupportedOperationException(
diff --git a/core/src/main/java/org/apache/iceberg/avro/ValueWriters.java b/core/src/main/java/org/apache/iceberg/avro/ValueWriters.java
index 6a38a96..02a4090 100644
--- a/core/src/main/java/org/apache/iceberg/avro/ValueWriters.java
+++ b/core/src/main/java/org/apache/iceberg/avro/ValueWriters.java
@@ -312,7 +312,7 @@ public class ValueWriters {
private DecimalWriter(int precision, int scale) {
this.precision = precision;
this.scale = scale;
- this.length = TypeUtil.decimalRequriedBytes(precision);
+ this.length = TypeUtil.decimalRequiredBytes(precision);
this.bytes = ThreadLocal.withInitial(() -> new byte[length]);
}
diff --git a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetAvro.java b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetAvro.java
index 9e6ad71..a417c48 100644
--- a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetAvro.java
+++ b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetAvro.java
@@ -304,7 +304,7 @@ class ParquetAvro {
} else {
return new ParquetDecimal(decimal.getPrecision(), decimal.getScale())
.addToSchema(Schema.createFixed(primitive.getName(),
- null, null, TypeUtil.decimalRequriedBytes(decimal.getPrecision())));
+ null, null, TypeUtil.decimalRequiredBytes(decimal.getPrecision())));
}
}
diff --git a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java
index a478ef7..18f1410 100644
--- a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java
+++ b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueWriters.java
@@ -190,7 +190,7 @@ public class ParquetValueWriters {
super(desc);
this.precision = precision;
this.scale = scale;
- this.length = TypeUtil.decimalRequriedBytes(precision);
+ this.length = TypeUtil.decimalRequiredBytes(precision);
this.bytes = ThreadLocal.withInitial(() -> new byte[length]);
}
diff --git a/parquet/src/main/java/org/apache/iceberg/parquet/TypeToMessageType.java b/parquet/src/main/java/org/apache/iceberg/parquet/TypeToMessageType.java
index 2757104..e4ffb75 100644
--- a/parquet/src/main/java/org/apache/iceberg/parquet/TypeToMessageType.java
+++ b/parquet/src/main/java/org/apache/iceberg/parquet/TypeToMessageType.java
@@ -165,7 +165,7 @@ public class TypeToMessageType {
} else {
// store as a fixed-length array
- int minLength = TypeUtil.decimalRequriedBytes(decimal.precision());
+ int minLength = TypeUtil.decimalRequiredBytes(decimal.precision());
return Types.primitive(FIXED_LEN_BYTE_ARRAY, repetition).length(minLength)
.as(DECIMAL)
.precision(decimal.precision())
diff --git a/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetWriters.java b/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetWriters.java
index 24b4e8e..3cd0d5e 100644
--- a/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetWriters.java
+++ b/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetWriters.java
@@ -299,7 +299,7 @@ public class SparkParquetWriters {
super(desc);
this.precision = precision;
this.scale = scale;
- this.length = TypeUtil.decimalRequriedBytes(precision);
+ this.length = TypeUtil.decimalRequiredBytes(precision);
this.bytes = ThreadLocal.withInitial(() -> new byte[length]);
}
diff --git a/spark/src/main/java/org/apache/iceberg/spark/data/SparkValueWriters.java b/spark/src/main/java/org/apache/iceberg/spark/data/SparkValueWriters.java
index aedd83e..fc519d1 100644
--- a/spark/src/main/java/org/apache/iceberg/spark/data/SparkValueWriters.java
+++ b/spark/src/main/java/org/apache/iceberg/spark/data/SparkValueWriters.java
@@ -120,7 +120,7 @@ public class SparkValueWriters {
private DecimalWriter(int precision, int scale) {
this.precision = precision;
this.scale = scale;
- this.length = TypeUtil.decimalRequriedBytes(precision);
+ this.length = TypeUtil.decimalRequiredBytes(precision);
this.bytes = ThreadLocal.withInitial(() -> new byte[length]);
}