You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/01 06:41:52 UTC

[GitHub] [hudi] vingov commented on a change in pull request #5125: [HUDI-3357] MVP implementation of BigQuerySyncTool

vingov commented on a change in pull request #5125:
URL: https://github.com/apache/hudi/pull/5125#discussion_r840280326



##########
File path: hudi-sync/pom.xml
##########
@@ -35,5 +35,6 @@
     <module>hudi-dla-sync</module>
     <module>hudi-hive-sync</module>
     <module>hudi-sync-common</module>
+    <module>hudi-bigquery-sync</module>

Review comment:
       I initially thought about it, then decided to go with bigquery name because, even without this bigquery sync, users can use hudi with gcp file system, I don't want to cause any confusion for the users, hence went ahead with bigquery and not gcp.
   
   Based on @vinothchandar's suggestion, if we plan to add more gcp eco-system tools in this module, then would it make sense to keep it under hudi-sync module or does it demand a higher level module say hudi-gcp?
   
   I'm okay to rename it after we decide on the correct strategy for future-proofing this module. 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org