You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/09 09:57:21 UTC
[GitHub] [skywalking] BFergerson commented on a change in pull request #5064: Better Vert.x endpoint names
BFergerson commented on a change in pull request #5064:
URL: https://github.com/apache/skywalking/pull/5064#discussion_r452103646
##########
File path: test/plugin/scenarios/vertx-web-3.54minus-scenario/config/expectedData.yaml
##########
@@ -97,10 +113,37 @@ segmentItems:
skipAnalysis: false
tags:
- {key: http.method, value: HEAD}
- - {key: url, value: /vertx-web-3_54minus-scenario/case/healthCheck}
+ - {key: url, value: '/vertx-web-3_54minus-scenario/case/healthCheck'}
+ - {key: status_code, value: '200'}
+ refs:
+ - {parentEndpoint: '{GET}/vertx-web-3_54minus-scenario/case/web-case', networkAddress: 'localhost:8080',
+ refType: CrossProcess, parentSpanId: 3, parentTraceSegmentId: not null,
+ parentServiceInstance: not null, parentService: vertx-web-3.54minus-scenario,
+ traceId: not null}
+ - segmentId: not null
+ spans:
+ - {operationName: org.apache.skywalking.apm.testcase.vertxweb.controller.VertxWebController$$Lambda$.handle(RoutingContext),
Review comment:
These operation names correspond to the lambdas which handle the response message. Like here: https://github.com/apache/skywalking/blob/6035f4869550009918b416df7811661c882f3de1/test/plugin/scenarios/vertx-web-3.6plus-scenario/src/main/java/org/apache/skywalking/apm/testcase/vertxweb/controller/VertxWebController.java#L47
What else would you call it? If a class and method name can be determined you get: https://github.com/apache/skywalking/blob/6035f4869550009918b416df7811661c882f3de1/test/plugin/scenarios/vertx-web-3.6plus-scenario/config/expectedData.yaml#L152. I can't get a method name for a lambda.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org