You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2024/10/09 21:25:23 UTC
[PR] Clarified return value in TabletInformation.getLocation javadoc [accumulo]
dlmarion opened a new pull request, #4967:
URL: https://github.com/apache/accumulo/pull/4967
Closes #4937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarified return value in TabletInformation.getLocation javadoc [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #4967:
URL: https://github.com/apache/accumulo/pull/4967#discussion_r1794393534
##########
core/src/main/java/org/apache/accumulo/core/client/admin/TabletInformation.java:
##########
@@ -59,7 +59,10 @@ public interface TabletInformation {
String getTabletState();
/**
- * @return the Location of the tablet as a String.
+ * @return the Location of the tablet as a String or empty if the location in the TabletMetadata
+ * does not exist. When not empty, the String will be of the form
+ * "{@code <location type>:<host>:<port>}", where the location type is one of
+ * {@code LocationType}.
Review Comment:
LocationType enum is defined outside of the public API, also this will only return two of the enums three values. Could just list them in the javadoc.
```suggestion
* {@code CURRENT} or {@code FUTURE}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clarified return value in TabletInformation.getLocation javadoc [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #4967:
URL: https://github.com/apache/accumulo/pull/4967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org