You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/27 07:00:55 UTC

[GitHub] [superset] villebro commented on a change in pull request #18171: fix: null value and empty string in filter

villebro commented on a change in pull request #18171:
URL: https://github.com/apache/superset/pull/18171#discussion_r793298694



##########
File path: superset/constants.py
##########
@@ -21,6 +21,7 @@
 from enum import Enum
 
 NULL_STRING = "<NULL>"
+EMPTY_STRING = "<empty string>"

Review comment:
       nit: should we align with the casing of `<NULL>`, i.e. rename this to `<EMPTY STRING>`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org