[GitHub] [spark] WeichenXu123 commented on a diff in pull request #40353: [SPARK-42732][PYSPARK][CONNECT] Support spark connect session getActiveSession method

["WeichenXu123 (via GitHub)" <gi...@apache.org>]

WeichenXu123 commented on code in PR #40353:
URL: https://github.com/apache/spark/pull/40353#discussion_r1130972732


##########
python/pyspark/sql/connect/session.py:
##########
@@ -119,7 +122,11 @@ def enableHiveSupport(self) -> "SparkSession.Builder":
             raise NotImplementedError("enableHiveSupport not implemented for Spark Connect")
 
         def getOrCreate(self) -> "SparkSession":
-            return SparkSession(connectionString=self._options["spark.remote"])

Review Comment:
   I don't think so.
   pyspark.sql.SparkSession also does not add lock when calling getOrCreate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org