You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by dh...@apache.org on 2023/01/02 08:26:34 UTC

[arrow-datafusion] branch master updated: uncomment nanosecond tests (#4789)

This is an automated email from the ASF dual-hosted git repository.

dheres pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git


The following commit(s) were added to refs/heads/master by this push:
     new 54ae4323a uncomment nanosecond tests (#4789)
54ae4323a is described below

commit 54ae4323a730a4a34c6b5f638e2083f0c3fe5dcc
Author: comphead <co...@users.noreply.github.com>
AuthorDate: Mon Jan 2 00:26:29 2023 -0800

    uncomment nanosecond tests (#4789)
---
 datafusion/core/tests/sql/expr.rs | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/datafusion/core/tests/sql/expr.rs b/datafusion/core/tests/sql/expr.rs
index c8248730e..01fd26723 100644
--- a/datafusion/core/tests/sql/expr.rs
+++ b/datafusion/core/tests/sql/expr.rs
@@ -1296,11 +1296,10 @@ async fn test_extract_date_part() -> Result<()> {
         "EXTRACT(microsecond FROM to_timestamp('2020-09-08T12:00:12.12345678+00:00'))",
         "12123456.78"
     );
-    // Depends on https://github.com/apache/arrow-datafusion/issues/4528
-    // test_expression!(
-    //     "EXTRACT(nanosecond FROM to_timestamp('2020-09-08T12:00:12.12345678+00:00'))",
-    //     "1212345678"
-    // );
+    test_expression!(
+        "EXTRACT(nanosecond FROM to_timestamp('2020-09-08T12:00:12.12345678+00:00'))",
+        "12123456780"
+    );
     test_expression!(
         "date_part('second', to_timestamp('2020-09-08T12:00:12.12345678+00:00'))",
         "12.12345678"
@@ -1389,8 +1388,13 @@ async fn test_extract_date_part_func() -> Result<()> {
         ),
         "true"
     );
-    // Depends on https://github.com/apache/arrow-datafusion/issues/4528
-    //test_expression!(format!("(date_part('{0}', now()) = EXTRACT({0} FROM now()))", "nanosecond"), "true");
+    test_expression!(
+        format!(
+            "(date_part('{0}', now()) = EXTRACT({0} FROM now()))",
+            "nanosecond"
+        ),
+        "true"
+    );
 
     Ok(())
 }