[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #14504: [Fix-14503][Worker] Fix the problem of subprocess cannot be killed

["ruanwenjun (via GitHub)" <gi...@apache.org>]

ruanwenjun commented on code in PR #14504:
URL: https://github.com/apache/dolphinscheduler/pull/14504#discussion_r1259832096


##########
dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/processor/WorkerTaskKillProcessor.java:
##########
@@ -98,6 +96,7 @@ public void process(Channel channel, Message message) {
             }
 
             boolean result = doKill(taskExecutionContext);
+            this.cancelApplication(taskInstanceId);

Review Comment:
   I hope we can remove the `doKill` method, the kill operation should be implemented by task plugin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org