You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/13 04:34:42 UTC
[jira] [Commented] (ARTEMIS-958) Improve web server tmp dir cleanup
[ https://issues.apache.org/jira/browse/ARTEMIS-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863197#comment-15863197 ]
ASF GitHub Bot commented on ARTEMIS-958:
----------------------------------------
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/1007
ARTEMIS-958 Improve web server tmp dir cleanup
When server is shutdown by user the shutdown hook will check if the tmpdir of the web server is cleaned up. However the cleanup is also performed in a shutdown hook (using File.deleteOnExit). Because the order of execution of hooks is not guaranteed, if the tmp dir is not cleaned up by the time of check, we should add a 'force' delete to make sure the tmp dir is removed after server stop.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-artemis master-tmpdir
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1007.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1007
----
commit 340c0b3e8c106554db6631950ee1ed5c2ecb5f45
Author: Howard Gao <ho...@gmail.com>
Date: 2017-02-13T03:45:41Z
ARTEMIS-958 Improve web server tmp dir cleanup
----
> Improve web server tmp dir cleanup
> ----------------------------------
>
> Key: ARTEMIS-958
> URL: https://issues.apache.org/jira/browse/ARTEMIS-958
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.5.2
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Minor
> Fix For: 2.0.0
>
>
> When server is shutdown by user the shutdown hook will check if the tmpdir of the web server is cleaned up. However the cleanup is also performed in a shutdown hook (using File.deleteOnExit). Because the order of execution of hooks is not guaranteed, if the tmp dir is not cleaned up by the time of check, we should add a 'force' delete to make sure the tmp dir is removed after server stop.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)