[GitHub] [carbondata] akashrn5 commented on a change in pull request #3980: [CARBONDATA-3901] [CARBONDATA-3903] [CARBONDATA-3824] SI creation on unkbown table and doc changes.

[GitBox <gi...@apache.org>]

akashrn5 commented on a change in pull request #3980:
URL: https://github.com/apache/carbondata/pull/3980#discussion_r507519490



##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/DDLStrategy.scala
##########
@@ -204,6 +204,10 @@ class DDLStrategy(sparkSession: SparkSession) extends SparkStrategy {
           ExecutedCommandExec(CarbonCreateSecondaryIndexCommand(
             indexModel, tableProperties, ifNotExists, isDeferredRefresh, isCreateSIndex)) :: Nil
         } else {
+          if (!sparkSession.sessionState.catalog.

Review comment:
       already we are calling `tableExists `funtion to check whether carbon table or not, if the table not found, it throws `NoSuchTableException`. But we catch the exception in `org.apache.spark.sql.hive.CarbonFileMetastore#tableExists` and return false. So you can add an error log in CarbonFileMetaStore, saying the table not exists mentioning table name and avoid the calling to hive metastore here in your changes which is a costly operation.
   
   Also, you can just change the error to more generalized way to satisfy the non-carbon table scenario and table not exists.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org