You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/09/13 14:08:02 UTC
[GitHub] [cordova-lib] raphinesse opened a new pull request #882: refactor(addHelper): more concise package.json spec lookup
raphinesse opened a new pull request #882:
URL: https://github.com/apache/cordova-lib/pull/882
Improves code and tests related to the code fixed in #874.
Marked as WIP since this PR builds onto #874.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] raphinesse merged pull request #882: refactor(addHelper): more concise package.json spec lookup
Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #882:
URL: https://github.com/apache/cordova-lib/pull/882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] codecov-commenter edited a comment on pull request #882: refactor(addHelper): more concise package.json spec lookup
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #882:
URL: https://github.com/apache/cordova-lib/pull/882#issuecomment-927300765
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#882](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de47a92) into [master](https://codecov.io/gh/apache/cordova-lib/commit/33ce4fe787f4ea1508f83787b2d50083c2ea0154?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33ce4fe) will **increase** coverage by `0.07%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head de47a92 differs from pull request most recent head 8ecbe8a. Consider uploading reports for the commit 8ecbe8a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/882/graphs/tree.svg?width=650&height=150&src=pr&token=KwBjKMXLqA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 91.13% 91.21% +0.07%
==========================================
Files 45 45
Lines 2053 2048 -5
==========================================
- Hits 1871 1868 -3
+ Misses 182 180 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/cordova/platform/addHelper.js](https://codecov.io/gh/apache/cordova-lib/pull/882/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmRvdmEvcGxhdGZvcm0vYWRkSGVscGVyLmpz) | `95.91% <100.00%> (+1.18%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33ce4fe...8ecbe8a](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-lib] codecov-commenter commented on pull request #882: refactor(addHelper): more concise package.json spec lookup
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #882:
URL: https://github.com/apache/cordova-lib/pull/882#issuecomment-927300765
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#882](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de47a92) into [master](https://codecov.io/gh/apache/cordova-lib/commit/33ce4fe787f4ea1508f83787b2d50083c2ea0154?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33ce4fe) will **increase** coverage by `0.07%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head de47a92 differs from pull request most recent head 8ecbe8a. Consider uploading reports for the commit 8ecbe8a to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-lib/pull/882/graphs/tree.svg?width=650&height=150&src=pr&token=KwBjKMXLqA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 91.13% 91.21% +0.07%
==========================================
Files 45 45
Lines 2053 2048 -5
==========================================
- Hits 1871 1868 -3
+ Misses 182 180 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/cordova/platform/addHelper.js](https://codecov.io/gh/apache/cordova-lib/pull/882/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvcmRvdmEvcGxhdGZvcm0vYWRkSGVscGVyLmpz) | `95.91% <100.00%> (+1.18%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33ce4fe...8ecbe8a](https://codecov.io/gh/apache/cordova-lib/pull/882?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org