You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "bigduu (via GitHub)" <gi...@apache.org> on 2023/03/14 15:56:31 UTC

[GitHub] [beam] bigduu opened a new pull request, #25843: fixes:#25841 Improve-error-messages-for-the-validateStateApplicableForInput-method…

bigduu opened a new pull request, #25843:
URL: https://github.com/apache/beam/pull/25843

   …-in-ParDO-so-that-they-are-more-helpful
   
   **Please** add a meaningful description for your change here
   The detail in the issue
   https://github.com/apache/beam/issues/25841
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #25843: fixes:#25841 Improve-error-messages-for-the-validateStateApplicableForInput-method…

Posted by "Abacn (via GitHub)" <gi...@apache.org>.

Abacn commented on code in PR #25843:
URL: https://github.com/apache/beam/pull/25843#discussion_r1211686767


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java:
##########
@@ -446,8 +446,8 @@ private static void validateStateApplicableForInput(PCollection<?> input) {
     } catch (Coder.NonDeterministicException exc) {
       throw new IllegalArgumentException(
           String.format(
-              "%s requires a deterministic key coder in order to use state and timers",
-              ParDo.class.getSimpleName()));
+              "%s requires a deterministic key coder in order to use state and timers, the reason is:\n\t %s",

Review Comment:
   ```suggestion
                 "%s requires a deterministic key coder in order to use state and timers, the reason is:%n %s",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #25843: fixes:#25841 Improve-error-messages-for-the-validateStateApplicableForInput-method…

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.

kennknowles commented on PR #25843:
URL: https://github.com/apache/beam/pull/25843#issuecomment-1480131715

   Run Java_Pulsar_IO_Direct PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn merged pull request #25843: fixes:#25841 Improve-error-messages-for-the-validateStateApplicableForInput-method…

Posted by "Abacn (via GitHub)" <gi...@apache.org>.

Abacn merged PR #25843:
URL: https://github.com/apache/beam/pull/25843


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] kennknowles commented on pull request #25843: fixes:#25841 Improve-error-messages-for-the-validateStateApplicableForInput-method…

Posted by "kennknowles (via GitHub)" <gi...@apache.org>.

kennknowles commented on PR #25843:
URL: https://github.com/apache/beam/pull/25843#issuecomment-1480131420

   Run Java_GCP_IO_Direct PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org