You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2013/04/29 11:06:15 UTC
[LANG] LANG-884 - OK to commit patch?
https://issues.apache.org/jira/browse/LANG-884 has a patch to simplify
FastDateFormat which I would like to apply.
OK?
Re: [LANG] LANG-884 - OK to commit patch?
Posted by Henri Yandell <fl...@gmail.com>.
+1 to committing.
On Mon, Apr 29, 2013 at 2:06 AM, sebb <se...@gmail.com> wrote:
> https://issues.apache.org/jira/browse/LANG-884 has a patch to simplify
> FastDateFormat which I would like to apply.
>
> OK?
>
Re: [LANG] LANG-884 - OK to commit patch?
Posted by sebb <se...@gmail.com>.
On 30 April 2013 00:20, Honton, Charles <Ch...@intuit.com> wrote:
> I am ambivalent. The change adds some, but not much extra clarity to the
> implementation. On the other hand, this change does change the public
> signatures of FormatCache. Is FormatCache considered part of the API?
>
>
No. It's package protected, otherwise I would not have been able to change
the visibility of the ctor.
chas
> ----
>
>
> On 4/29/13 2:06 AM, "sebb" <se...@gmail.com> wrote:
>
> >https://issues.apache.org/jira/browse/LANG-884 has a patch to simplify
> >FastDateFormat which I would like to apply.
> >
> >OK?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [LANG] LANG-884 - OK to commit patch?
Posted by "Honton, Charles" <Ch...@intuit.com>.
I am ambivalent. The change adds some, but not much extra clarity to the
implementation. On the other hand, this change does change the public
signatures of FormatCache. Is FormatCache considered part of the API?
chas
----
On 4/29/13 2:06 AM, "sebb" <se...@gmail.com> wrote:
>https://issues.apache.org/jira/browse/LANG-884 has a patch to simplify
>FastDateFormat which I would like to apply.
>
>OK?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org