You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Ryan Thompson via dev <de...@beam.apache.org> on 2022/09/06 19:05:09 UTC
Upcoming potentially breaking change to CoGroupByKey
CoGroupByKey returns a dictionary of {KeyType, List[ValueType]} but, as
GroupByKey, should return an Iterable.
Change:
https://github.com/apache/beam/pull/22984
Please look at this doc
<https://docs.google.com/document/d/1RIzm8-g-0CyVsPb6yasjwokJQFoKHG4NjRUcKHKINu0>
if you need more details. Feel free to comment.
Re: Upcoming potentially breaking change to CoGroupByKey
Posted by Robert Burke via dev <de...@beam.apache.org>.
"new release" is an ambiguous descriptor in this email. I'm going to
continue to take it as "right after the 2.42.0 cut, to make it into the
2.43.0 as planned".
On Tue, Sep 6, 2022 at 2:39 PM Ryan Thompson <ry...@google.com>
wrote:
> There was discussion in the python meeting to try to get this into the new
> release. The consensus was that putting it in right after the release had
> the highest chance of catching problems with the least amount of pain.
>
> I can send it out to users next week if nother halts the change.
>
> On Tue, Sep 6, 2022 at 5:03 PM Luke Cwik <lc...@google.com> wrote:
>
>> We should send this out to users@beam.apache.org so that they are aware
>> of this change once commenting in the doc has settled.
>>
>> On Tue, Sep 6, 2022 at 1:59 PM Robert Burke <ro...@frantil.com> wrote:
>>
>>> Thank you for already planning to *NOT* have this merged until after
>>> this week's 2.42.0 cut. This Release Manager is pleased that the doc says
>>> it's intended for 2.43.0.
>>>
>>>
>>> On Tue, Sep 6, 2022, 1:44 PM Ryan Thompson via dev <de...@beam.apache.org>
>>> wrote:
>>>
>>>> CoGroupByKey returns a dictionary of {KeyType, List[ValueType]} but, as
>>>> GroupByKey, should return an Iterable.
>>>>
>>>> Change:
>>>> https://github.com/apache/beam/pull/22984
>>>>
>>>> Please look at this doc
>>>> <https://docs.google.com/document/d/1RIzm8-g-0CyVsPb6yasjwokJQFoKHG4NjRUcKHKINu0>
>>>> if you need more details. Feel free to comment.
>>>>
>>>>
Re: Upcoming potentially breaking change to CoGroupByKey
Posted by Ryan Thompson via dev <de...@beam.apache.org>.
There was discussion in the python meeting to try to get this into the new
release. The consensus was that putting it in right after the release had
the highest chance of catching problems with the least amount of pain.
I can send it out to users next week if nother halts the change.
On Tue, Sep 6, 2022 at 5:03 PM Luke Cwik <lc...@google.com> wrote:
> We should send this out to users@beam.apache.org so that they are aware
> of this change once commenting in the doc has settled.
>
> On Tue, Sep 6, 2022 at 1:59 PM Robert Burke <ro...@frantil.com> wrote:
>
>> Thank you for already planning to *NOT* have this merged until after this
>> week's 2.42.0 cut. This Release Manager is pleased that the doc says it's
>> intended for 2.43.0.
>>
>>
>> On Tue, Sep 6, 2022, 1:44 PM Ryan Thompson via dev <de...@beam.apache.org>
>> wrote:
>>
>>> CoGroupByKey returns a dictionary of {KeyType, List[ValueType]} but, as
>>> GroupByKey, should return an Iterable.
>>>
>>> Change:
>>> https://github.com/apache/beam/pull/22984
>>>
>>> Please look at this doc
>>> <https://docs.google.com/document/d/1RIzm8-g-0CyVsPb6yasjwokJQFoKHG4NjRUcKHKINu0>
>>> if you need more details. Feel free to comment.
>>>
>>>
Re: Upcoming potentially breaking change to CoGroupByKey
Posted by Luke Cwik via dev <de...@beam.apache.org>.
We should send this out to users@beam.apache.org so that they are aware of
this change once commenting in the doc has settled.
On Tue, Sep 6, 2022 at 1:59 PM Robert Burke <ro...@frantil.com> wrote:
> Thank you for already planning to *NOT* have this merged until after this
> week's 2.42.0 cut. This Release Manager is pleased that the doc says it's
> intended for 2.43.0.
>
>
> On Tue, Sep 6, 2022, 1:44 PM Ryan Thompson via dev <de...@beam.apache.org>
> wrote:
>
>> CoGroupByKey returns a dictionary of {KeyType, List[ValueType]} but, as
>> GroupByKey, should return an Iterable.
>>
>> Change:
>> https://github.com/apache/beam/pull/22984
>>
>> Please look at this doc
>> <https://docs.google.com/document/d/1RIzm8-g-0CyVsPb6yasjwokJQFoKHG4NjRUcKHKINu0>
>> if you need more details. Feel free to comment.
>>
>>
Re: Upcoming potentially breaking change to CoGroupByKey
Posted by Robert Burke <ro...@frantil.com>.
Thank you for already planning to *NOT* have this merged until after this
week's 2.42.0 cut. This Release Manager is pleased that the doc says it's
intended for 2.43.0.
On Tue, Sep 6, 2022, 1:44 PM Ryan Thompson via dev <de...@beam.apache.org>
wrote:
> CoGroupByKey returns a dictionary of {KeyType, List[ValueType]} but, as
> GroupByKey, should return an Iterable.
>
> Change:
> https://github.com/apache/beam/pull/22984
>
> Please look at this doc
> <https://docs.google.com/document/d/1RIzm8-g-0CyVsPb6yasjwokJQFoKHG4NjRUcKHKINu0>
> if you need more details. Feel free to comment.
>
>