You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/03/19 16:10:25 UTC
Review Request 19399: CLOUDSTACK-6257: Resolving issue in template creation
from user VM volume,
added method to check the state of VM before template creation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Bugs: CLOUDSTACK-6257
https://issues.apache.org/jira/browse/CLOUDSTACK-6257
Repository: cloudstack-git
Description
-------
As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
Diffs
-----
test/integration/component/test_project_usage.py ba0a63c
test/integration/component/test_resource_limits.py f0d558e
test/integration/component/test_tags.py 2a6e076
test/integration/component/test_templates.py 3e83615
test/integration/component/test_usage.py 5979a0a
tools/marvin/marvin/integration/lib/base.py 775b289
Diff: https://reviews.apache.org/r/19399/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On March 19, 2014, 3:32 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_usage.py, line 680
> > <https://reviews.apache.org/r/19399/diff/1/?file=528014#file528014line680>
> >
> > Also, just a thought. If stop operation itself verifies the state and return, so test case can check some thing like if virtual_machine.stop() == FAIL:
> > raise\fail. I believe we can use getState inside stop operation itself. Basically, stop operation return can be enforced and checked.
> >
>
> Ashutosh Kelkar wrote:
> Here if we don't want to touch existing test cases with stop operation, we will have to raise Exception through stop method if getState return FAIL to Stop method. Is that ok?
>
> Santhosh Edukulla wrote:
> That should be fine.
Ok I will update the patch with that change.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review37723
-----------------------------------------------------------
On March 20, 2014, 11:56 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 11:56 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_project_usage.py ba0a63c
> test/integration/component/test_resource_limits.py f0d558e
> test/integration/component/test_tags.py 2a6e076
> test/integration/component/test_templates.py 3e83615
> test/integration/component/test_usage.py 5979a0a
> tools/marvin/marvin/codes.py e4a0f6a
> tools/marvin/marvin/integration/lib/base.py 775b289
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On March 19, 2014, 3:32 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_usage.py, line 680
> > <https://reviews.apache.org/r/19399/diff/1/?file=528014#file528014line680>
> >
> > Also, just a thought. If stop operation itself verifies the state and return, so test case can check some thing like if virtual_machine.stop() == FAIL:
> > raise\fail. I believe we can use getState inside stop operation itself. Basically, stop operation return can be enforced and checked.
> >
Here if we don't want to touch existing test cases with stop operation, we will have to raise Exception through stop method if getState return FAIL to Stop method. Is that ok?
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review37723
-----------------------------------------------------------
On March 19, 2014, 3:10 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 3:10 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_project_usage.py ba0a63c
> test/integration/component/test_resource_limits.py f0d558e
> test/integration/component/test_tags.py 2a6e076
> test/integration/component/test_templates.py 3e83615
> test/integration/component/test_usage.py 5979a0a
> tools/marvin/marvin/integration/lib/base.py 775b289
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On March 19, 2014, 3:32 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_usage.py, line 680
> > <https://reviews.apache.org/r/19399/diff/1/?file=528014#file528014line680>
> >
> > Also, just a thought. If stop operation itself verifies the state and return, so test case can check some thing like if virtual_machine.stop() == FAIL:
> > raise\fail. I believe we can use getState inside stop operation itself. Basically, stop operation return can be enforced and checked.
> >
>
> Ashutosh Kelkar wrote:
> Here if we don't want to touch existing test cases with stop operation, we will have to raise Exception through stop method if getState return FAIL to Stop method. Is that ok?
That should be fine.
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review37723
-----------------------------------------------------------
On March 20, 2014, 11:56 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated March 20, 2014, 11:56 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_project_usage.py ba0a63c
> test/integration/component/test_resource_limits.py f0d558e
> test/integration/component/test_tags.py 2a6e076
> test/integration/component/test_templates.py 3e83615
> test/integration/component/test_usage.py 5979a0a
> tools/marvin/marvin/codes.py e4a0f6a
> tools/marvin/marvin/integration/lib/base.py 775b289
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review37723
-----------------------------------------------------------
test/integration/component/test_usage.py
<https://reviews.apache.org/r/19399/#comment69370>
Also, just a thought. If stop operation itself verifies the state and return, so test case can check some thing like if virtual_machine.stop() == FAIL:
raise\fail. I believe we can use getState inside stop operation itself. Basically, stop operation return can be enforced and checked.
tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/19399/#comment69366>
Add other states for VM as well. If anybody wanted to use it, they can use these states, otherwise they have to touch this library again.
tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/19399/#comment69368>
Move this inside try block.
tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/19399/#comment69369>
Just reorganize while loop, and use while timeout rather than while True. So, we dont need separate elif.
tools/marvin/marvin/integration/lib/base.py
<https://reviews.apache.org/r/19399/#comment69364>
This else can be removed i believe. Also , continue is not required.
- Santhosh Edukulla
On March 19, 2014, 3:10 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 3:10 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_project_usage.py ba0a63c
> test/integration/component/test_resource_limits.py f0d558e
> test/integration/component/test_tags.py 2a6e076
> test/integration/component/test_templates.py 3e83615
> test/integration/component/test_usage.py 5979a0a
> tools/marvin/marvin/integration/lib/base.py 775b289
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review39872
-----------------------------------------------------------
Santhosh, can you please review this? Review changes have been incorporated.
- Ashutosh Kelkar
On March 21, 2014, 2:28 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 2:28 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_project_usage.py ba0a63c
> test/integration/component/test_resource_limits.py f0d558e
> test/integration/component/test_tags.py 2a6e076
> test/integration/component/test_templates.py 3e83615
> test/integration/component/test_usage.py 5979a0a
> tools/marvin/marvin/codes.py e4a0f6a
> tools/marvin/marvin/integration/lib/base.py 775b289
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On April 9, 2014, 10:08 a.m., Santhosh Edukulla wrote:
> > Ship It!
Patch fails to apply on master. Please rebase it against the master and check.
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review39875
-----------------------------------------------------------
On March 21, 2014, 2:28 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 2:28 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_project_usage.py ba0a63c
> test/integration/component/test_resource_limits.py f0d558e
> test/integration/component/test_tags.py 2a6e076
> test/integration/component/test_templates.py 3e83615
> test/integration/component/test_usage.py 5979a0a
> tools/marvin/marvin/codes.py e4a0f6a
> tools/marvin/marvin/integration/lib/base.py 775b289
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review39875
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On March 21, 2014, 2:28 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 2:28 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_project_usage.py ba0a63c
> test/integration/component/test_resource_limits.py f0d558e
> test/integration/component/test_tags.py 2a6e076
> test/integration/component/test_templates.py 3e83615
> test/integration/component/test_usage.py 5979a0a
> tools/marvin/marvin/codes.py e4a0f6a
> tools/marvin/marvin/integration/lib/base.py 775b289
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review39871
-----------------------------------------------------------
Santhosh, can you please review this? Review changes have been incorporated.
- Ashutosh Kelkar
On March 21, 2014, 2:28 p.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 2:28 p.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> test/integration/component/test_project_usage.py ba0a63c
> test/integration/component/test_resource_limits.py f0d558e
> test/integration/component/test_tags.py 2a6e076
> test/integration/component/test_templates.py 3e83615
> test/integration/component/test_usage.py 5979a0a
> tools/marvin/marvin/codes.py e4a0f6a
> tools/marvin/marvin/integration/lib/base.py 775b289
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by sanjeev n <sa...@citrix.com>.
> On May 5, 2014, 5:53 a.m., ASF Subversion and Git Services wrote:
> > Commit d81c5c44f112df8c0e4388e9d88300b24eefe3d0 in cloudstack's branch refs/heads/4.4-forward from Girish Shilamkar
> > [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d81c5c4 ]
> >
> > Revert "CLOUDSTACK-6257: Adding function to check state of VM"
> >
> > This reverts commit 1be8b87fb7fb0203464ac4c66596008855ac5041.
> >
Hi Girish,
Why was this commit not reverted from master branch. If it was not reverted was there a fix for this patch in master?
- sanjeev
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review42119
-----------------------------------------------------------
On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 10:41 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/codes.py 28e907c
> tools/marvin/marvin/lib/base.py d753098
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review42119
-----------------------------------------------------------
Commit d81c5c44f112df8c0e4388e9d88300b24eefe3d0 in cloudstack's branch refs/heads/4.4-forward from Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d81c5c4 ]
Revert "CLOUDSTACK-6257: Adding function to check state of VM"
This reverts commit 1be8b87fb7fb0203464ac4c66596008855ac5041.
- ASF Subversion and Git Services
On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 10:41 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/codes.py 28e907c
> tools/marvin/marvin/lib/base.py d753098
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review42271
-----------------------------------------------------------
Commit 6598167bedb1f00e9d1efc12b82999f8e822d5d6 in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6598167 ]
CLOUDSTACK-6257: Adding function to check the VM state
- ASF Subversion and Git Services
On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 10:41 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/codes.py 28e907c
> tools/marvin/marvin/lib/base.py d753098
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review42032
-----------------------------------------------------------
Commit 1be8b87fb7fb0203464ac4c66596008855ac5041 in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1be8b87 ]
CLOUDSTACK-6257: Adding function to check state of VM
Conflicts:
tools/marvin/marvin/integration/lib/base.py
- ASF Subversion and Git Services
On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 10:41 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/codes.py 28e907c
> tools/marvin/marvin/lib/base.py d753098
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review42136
-----------------------------------------------------------
Tried to apply it on master but it failed. Please rebase with master. Error messages are as follows:
[root@cent62-Sanjeev acs-repo]# git apply /root/0001-CLOUDSTACK-6257-Adding-function-to-check-state-of-VM.patch
error: patch failed: tools/marvin/marvin/codes.py:31
error: tools/marvin/marvin/codes.py: patch does not apply
error: patch failed: tools/marvin/marvin/lib/base.py:22
error: tools/marvin/marvin/lib/base.py: patch does not apply
- sanjeev n
On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 10:41 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/codes.py 28e907c
> tools/marvin/marvin/lib/base.py d753098
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/#review42031
-----------------------------------------------------------
Commit 59d0b75e7943505c11d6b726d7aa9dae0bf06316 in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=59d0b75 ]
CLOUDSTACK-6257: Adding function to check state of VM
- ASF Subversion and Git Services
On April 28, 2014, 10:41 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19399/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 10:41 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-6257
> https://issues.apache.org/jira/browse/CLOUDSTACK-6257
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/codes.py 28e907c
> tools/marvin/marvin/lib/base.py d753098
>
> Diff: https://reviews.apache.org/r/19399/diff/
>
>
> Testing
> -------
>
> Yes.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/
-----------------------------------------------------------
(Updated April 28, 2014, 10:41 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Rebased against latest Master. Including only library changes here. Will add test cases changes later after testing. We can commit this change as it is independent.
Bugs: CLOUDSTACK-6257
https://issues.apache.org/jira/browse/CLOUDSTACK-6257
Repository: cloudstack-git
Description
-------
As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
Diffs (updated)
-----
tools/marvin/marvin/codes.py 28e907c
tools/marvin/marvin/lib/base.py d753098
Diff: https://reviews.apache.org/r/19399/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/
-----------------------------------------------------------
(Updated March 21, 2014, 2:28 p.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Review changes.
Bugs: CLOUDSTACK-6257
https://issues.apache.org/jira/browse/CLOUDSTACK-6257
Repository: cloudstack-git
Description
-------
As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
Diffs (updated)
-----
test/integration/component/test_project_usage.py ba0a63c
test/integration/component/test_resource_limits.py f0d558e
test/integration/component/test_tags.py 2a6e076
test/integration/component/test_templates.py 3e83615
test/integration/component/test_usage.py 5979a0a
tools/marvin/marvin/codes.py e4a0f6a
tools/marvin/marvin/integration/lib/base.py 775b289
Diff: https://reviews.apache.org/r/19399/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar
Re: Review Request 19399: CLOUDSTACK-6257: Resolving issue in template
creation from user VM volume,
added method to check the state of VM before template creation
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19399/
-----------------------------------------------------------
(Updated March 20, 2014, 11:56 a.m.)
Review request for cloudstack and Santhosh Edukulla.
Changes
-------
Review changes.
Bugs: CLOUDSTACK-6257
https://issues.apache.org/jira/browse/CLOUDSTACK-6257
Repository: cloudstack-git
Description
-------
As suggested, added getState method for VirtualMachine class, and it is called before template creation. If VM fails to go into desired state, it returns failure.
Diffs (updated)
-----
test/integration/component/test_project_usage.py ba0a63c
test/integration/component/test_resource_limits.py f0d558e
test/integration/component/test_tags.py 2a6e076
test/integration/component/test_templates.py 3e83615
test/integration/component/test_usage.py 5979a0a
tools/marvin/marvin/codes.py e4a0f6a
tools/marvin/marvin/integration/lib/base.py 775b289
Diff: https://reviews.apache.org/r/19399/diff/
Testing
-------
Yes.
Thanks,
Ashutosh Kelkar