You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/08/19 19:07:35 UTC

[GitHub] [skywalking] tom-pytel opened a new pull request, #9490: Add AsyncPG and AIORedis components for Python plugin

tom-pytel opened a new pull request, #9490:
URL: https://github.com/apache/skywalking/pull/9490

   Component IDs for [#230](https://github.com/apache/skywalking-python/pull/230)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] tom-pytel commented on pull request #9490: Add AsyncPG and AIORedis components for Python plugin

Posted by GitBox <gi...@apache.org>.
tom-pytel commented on PR #9490:
URL: https://github.com/apache/skywalking/pull/9490#issuecomment-1221274006

   > I think we would need your PR to add new icons for UI?
   
   I didn't find any specific icons for these, they are just Postgres and Redis clients, could reuse those icons?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] wu-sheng commented on pull request #9490: Add AsyncPG and AIORedis components for Python plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9490:
URL: https://github.com/apache/skywalking/pull/9490#issuecomment-1221292977

   Then you should add mappings in this file, map this client component to server.
   Then when exit span accessing the server, the server could show the correct icon.
   Check the bottom of the file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] wu-sheng merged pull request #9490: Add AsyncPG and AIORedis components for Python plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #9490:
URL: https://github.com/apache/skywalking/pull/9490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] wu-sheng commented on pull request #9490: Add AsyncPG and AIORedis components for Python plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #9490:
URL: https://github.com/apache/skywalking/pull/9490#issuecomment-1221194605

   I think we would need your PR to add new icons for UI?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org