You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2017/01/09 17:28:12 UTC
[Bug 60564] New: Migrating LogKit to SLF4J - Replace logkit loggers
with slf4j ones with keeping the current logkit binding solution
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
Bug ID: 60564
Summary: Migrating LogKit to SLF4J - Replace logkit loggers
with slf4j ones with keeping the current logkit
binding solution
Product: JMeter
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Main
Assignee: issues@jmeter.apache.org
Reporter: woonsan@apache.org
Target Milestone: ---
As being discussed in the dev thread [1], the first step would be to replace
each logkit logger with slf4j logger.
An example:
[AS-IS]
public class HTMLAssertionGui extends AbstractAssertionGui implements
KeyListener, ActionListener {
private static final Logger log = LoggingManager.getLoggerForClass();
[TO-BE]
public class HTMLAssertionGui extends AbstractAssertionGui implements
KeyListener, ActionListener {
private static final Logger log =
LoggerFactory.getLogger(HTMLAssertionGui.class);
[1] http://markmail.org/thread/tloqa5zmuj26nrqn
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrating LogKit to SLF4J - Replace logkit loggers with
slf4j ones with keeping the current logkit binding solution
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
--- Comment #7 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Feb 5 22:22:46 2017
New Revision: 1781817
URL: http://svn.apache.org/viewvc?rev=1781817&view=rev
Log:
Bug 60564 - Migrating LogKit to SLF4J - Replace logkit loggers with slf4j ones
with keeping the current logkit binding solution
Use slf4j parameterized messages
Bugzilla Id: 60564
Modified:
jmeter/trunk/src/junit/org/apache/jmeter/protocol/java/control/gui/JUnitTestSamplerGui.java
jmeter/trunk/src/junit/org/apache/jmeter/protocol/java/sampler/JUnitSampler.java
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrating LogKit to SLF4J - Replace logkit loggers with
slf4j ones with keeping the current logkit binding solution
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |60565
Referenced Bugs:
https://bz.apache.org/bugzilla/show_bug.cgi?id=60565
[Bug 60565] Migrating LogKit to SLF4J - Optimize logging statements. e.g,
message format args, throwable args, unnecessary if-enabled-logging in simple
ones, etc.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrating LogKit to SLF4J - Replace logkit loggers with
slf4j ones with keeping the current logkit binding solution
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
--- Comment #5 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Thanks for contribution.
I merged it partially excluding the classes that are port of Client API:
- AbstractJavaSamplerClient through getLogger
- JSR223 Sampler
- BSF Sampler
- Beanshell Sampler
I'm afraid that to keep backward compatibility we need to keep them.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrate LogKit to SLF4J - Replace logkit loggers with
slf4j ones and keep the current logkit binding solution for backward
compatibility with plugins
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #10 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
PR Merger: pmouawad
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Author : Woonsan Ko
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Date: Sat Feb 11 08:35:08 2017
New Revision: 1782556
URL: http://svn.apache.org/viewvc?rev=1782556&view=rev
Log:
Bug 60564 - Migrate LogKit to SLF4J - Replace logkit loggers with slf4j ones
and keep the current logkit binding solution for backward compatibility with
plugins
Contributed by Woonsan Ko
Done by PRs 263 to 274
Bugzilla Id: 60565
Modified:
jmeter/trunk/xdocs/changes.xml
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrating LogKit to SLF4J - Replace logkit loggers with
slf4j ones with keeping the current logkit binding solution
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
--- Comment #6 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Feb 5 22:18:49 2017
New Revision: 1781816
URL: http://svn.apache.org/viewvc?rev=1781816&view=rev
Log:
Bug 60564 - Migrating LogKit to SLF4J - Replace logkit loggers with slf4j ones
with keeping the current logkit binding solution
Use slf4j parameterized messages
Bugzilla Id: 60564
Modified:
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/Utils.java
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/InitialContextFactory.java
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/Publisher.java
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/client/ReceiveSubscriber.java
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPropertiesPanel.java
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/BaseJMSSampler.java
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/FixedQueueExecutor.java
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/MessageAdmin.java
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/PublisherSampler.java
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/Receiver.java
jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/SubscriberSampler.java
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrating LogKit to SLF4J - Replace logkit loggers with
slf4j ones with keeping the current logkit binding solution
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|unspecified |3.1
CC| |p.mouawad@ubik-ingenierie.c
| |om
Severity|normal |enhancement
--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hello Woonsan Ko,
You can proceed, I suggest you provide patches or github PR the following way:
- For now avoid touching classes mentionned in PR 245 to 247 and 237, 240
- Group patches , 1 per packages , and for reduced components you can provide a
patch for the component for example protocol/ftp...
Thank a lot for your work.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrating LogKit to SLF4J - Replace logkit loggers with
slf4j ones with keeping the current logkit binding solution
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
--- Comment #9 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Feb 5 22:56:26 2017
New Revision: 1781828
URL: http://svn.apache.org/viewvc?rev=1781828&view=rev
Log:
Bug 60564 - Migrating LogKit to SLF4J - Replace logkit loggers with slf4j ones
with keeping the current logkit binding solution
Bugzilla Id: 60564
Modified:
jmeter/trunk/src/protocol/mongodb/org/apache/jmeter/protocol/mongodb/config/MongoSourceElement.java
jmeter/trunk/src/protocol/mongodb/org/apache/jmeter/protocol/mongodb/config/MongoSourceElementBeanInfo.java
jmeter/trunk/src/protocol/mongodb/org/apache/jmeter/protocol/mongodb/mongo/MongoDB.java
jmeter/trunk/src/protocol/mongodb/org/apache/jmeter/protocol/mongodb/sampler/MongoScriptRunner.java
jmeter/trunk/src/protocol/mongodb/org/apache/jmeter/protocol/mongodb/sampler/MongoScriptSampler.java
jmeter/trunk/src/protocol/mongodb/org/apache/jmeter/protocol/mongodb/sampler/MongoScriptSamplerBeanInfo.java
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrating LogKit to SLF4J - Replace logkit loggers with
slf4j ones with keeping the current logkit binding solution
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
--- Comment #8 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Feb 5 22:35:34 2017
New Revision: 1781825
URL: http://svn.apache.org/viewvc?rev=1781825&view=rev
Log:
Bug 60564 - Migrating LogKit to SLF4J - Replace logkit loggers with slf4j ones
with keeping the current logkit binding solution
Bugzilla Id: 60564
Modified:
jmeter/trunk/src/protocol/native/org/apache/jmeter/protocol/system/SystemSampler.java
jmeter/trunk/src/protocol/native/org/apache/jmeter/protocol/system/gui/SystemSamplerGui.java
Author: pmouawad
Date: Sun Feb 5 22:39:54 2017
New Revision: 1781826
URL: http://svn.apache.org/viewvc?rev=1781826&view=rev
Log:
Bug 60564 - Migrating LogKit to SLF4J - Replace logkit loggers with slf4j ones
with keeping the current logkit binding solution
Modified:
jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/BinaryTCPClientImpl.java
jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/LengthPrefixedBinaryTCPClientImpl.java
jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPClientImpl.java
jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrating LogKit to SLF4J - Replace logkit loggers with
slf4j ones with keeping the current logkit binding solution
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
--- Comment #3 from Woonsan Ko <wo...@apache.org> ---
First PR: https://github.com/apache/jmeter/pull/250, for protocol/java
component only for easier review/merge.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrating LogKit to SLF4J - Replace logkit loggers with
slf4j ones with keeping the current logkit binding solution
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Author: pmouawad
Date: Sun Feb 5 21:13:34 2017
New Revision: 1781806
URL: http://svn.apache.org/viewvc?rev=1781806&view=rev
Log:
Bug 60564 - Migrating LogKit to SLF4J - Replace logkit loggers with slf4j ones
with keeping the current logkit binding solution
Contributed by Woonsan Ko
This closes #250
Bugzilla Id: 60564
Modified:
jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/config/JavaConfig.java
jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/config/gui/JavaConfigGui.java
jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/AbstractJavaSamplerClient.java
jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/JavaSampler.java
jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/JavaSamplerContext.java
jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/JavaTest.java
jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/test/SleepTest.java
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrate LogKit to SLF4J - Replace logkit loggers with
slf4j ones and keep the current logkit binding solution for backward
compatibility with plugins
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
Philippe Mouawad <p....@ubik-ingenierie.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Migrating LogKit to SLF4J - |Migrate LogKit to SLF4J -
|Replace logkit loggers with |Replace logkit loggers with
|slf4j ones with keeping the |slf4j ones and keep the
|current logkit binding |current logkit binding
|solution |solution for backward
| |compatibility with plugins
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 60564] Migrating LogKit to SLF4J - Replace logkit loggers with
slf4j ones with keeping the current logkit binding solution
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60564
--- Comment #1 from Jerome <lo...@gmail.com> ---
That would be awesome, you have my support. Having Avalon, Excalibur and Log4j
all in the classpath of our application is a pain. For each jmeter maven
artifact we import, we need to duplicate a huge exclusion list to avoid
conflicts with internal modules.
--
You are receiving this mail because:
You are the assignee for the bug.