[jira] [Commented] (SLIDER-1151) Don't log Invalid port range values when there are no invalid ports specified

["Gour Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLIDER-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366781#comment-15366781 ] 

Gour Saha commented on SLIDER-1151:
-----------------------------------

[~manojsamel] feel free to submit a patch. Seems like you have already done code level analysis. It will be easier for the community to accept the patch from you, rather than waiting for someone to work on it. I can assign the bug to you as well.

> Don't log Invalid port range values when there are no invalid ports specified
> -----------------------------------------------------------------------------
>
>                 Key: SLIDER-1151
>                 URL: https://issues.apache.org/jira/browse/SLIDER-1151
>             Project: Slider
>          Issue Type: Improvement
>          Components: agent
>    Affects Versions: Slider 0.80
>            Reporter: Manoj Samel
>            Priority: Minor
>
> Slider version 0.80
> CustomServiceOrchestrator.py:494 (get_allowed_port_list()) always logs invalid port range log message; even when the "invalid" set is empty. 
> logger.warning("Invalid port range values: " + str(invalid))
> This just clutters the log with entries like 
> WARNING 2016-07-02 09:13:18,489 CustomServiceOrchestrator.py:494 - Invalid port range values: set([])
> The warning should be logged only when the invalid set is non-empty 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)