You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2014/10/03 09:34:28 UTC

[jclouds] Fix checkstyle failures on master (#537)

The first commit (to checkstyle.xml itself) is just cleanup
You can merge this Pull Request by running:

  git pull https://github.com/jclouds/jclouds fix-checkstyle

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/537

-- Commit Summary --

  * Aligning indents in checkstyle config file
  * Excluding checkstyle.xml from Checkstyle checking

-- File Changes --

    M project/pom.xml (2)
    M resources/checkstyle.xml (6)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/537.patch
https://github.com/jclouds/jclouds/pull/537.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/537

Re: [jclouds] Fix checkstyle failures on master (#537)

Posted by Andrew Phillips <no...@github.com>.
> but +1 for the current approach excluding the checkstyle.xml file.

Thanks, @nacx! Merged to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=641bc6fda0527fd828697081b565a0b2a5e3fdec)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/537#issuecomment-57797635

Re: [jclouds] Fix checkstyle failures on master (#537)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #1682](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1682/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/537#issuecomment-57768827

Re: [jclouds] Fix checkstyle failures on master (#537)

Posted by Andrew Phillips <no...@github.com>.
Erm...so that helped, but unfortunately this is not fixed yet. See [this comment](https://github.com/jclouds/jclouds/commit/641bc6fda0527fd828697081b565a0b2a5e3fdec#commitcomment-8029750)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/537#issuecomment-57832002

Re: [jclouds] Fix checkstyle failures on master (#537)

Posted by Andrew Phillips <no...@github.com>.
Closed #537.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/537#event-173798285

Re: [jclouds] Fix checkstyle failures on master (#537)

Posted by Andrew Phillips <no...@github.com>.
> @@ -1106,6 +1106,8 @@
>                <configLocation>resources/checkstyle.xml</configLocation>
>                <failOnViolation>true</failOnViolation>
>                <failsOnError>true</failsOnError>
> +              <!-- fails on itself as it uses the author tag in a module definition -->
> +              <resourceExcludes>checkstyle.xml</resourceExcludes>

Other options here:

* do not add the exclude at this level, but override the plugin config in resources/pom.xml
* use a [suppressions filter](http://maven.apache.org/plugins/maven-checkstyle-plugin/examples/suppressions-filter.html) instead. That would narrow down the exception, but the line numbers would go out of sync pretty quickly as checkstyle.xml is updated, I suspect
* add [`<property name="fileExtension" value="java">`](http://checkstyle.sourceforge.net/config_regexp.html) or so to the `@author` module config. But we probably want to check all files (well, _except_ checkstyle.xml) for this tag

@andrewgaul Thoughts?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/537/files#r18384166

Re: [jclouds] Fix checkstyle failures on master (#537)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1203](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1203/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/537#issuecomment-57770321

Re: [jclouds] Fix checkstyle failures on master (#537)

Posted by Ignasi Barrera <no...@github.com>.
> @@ -1106,6 +1106,8 @@
>                <configLocation>resources/checkstyle.xml</configLocation>
>                <failOnViolation>true</failOnViolation>
>                <failsOnError>true</failsOnError>
> +              <!-- fails on itself as it uses the author tag in a module definition -->
> +              <resourceExcludes>checkstyle.xml</resourceExcludes>

I'm not the expert here, but +1 for the current approach excluding the checkstyle.xml file.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/537/files#r18384251

Re: [jclouds] Fix checkstyle failures on master (#537)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #114](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/114/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/537#issuecomment-57764855