You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Eldon Stegall (JIRA)" <ji...@apache.org> on 2012/07/25 22:23:33 UTC

[jira] [Created] (THRIFT-1659) Bring nodejs default transport in line with Java default transport

Eldon Stegall created THRIFT-1659:
-------------------------------------

             Summary: Bring nodejs default transport in line with Java default transport
                 Key: THRIFT-1659
                 URL: https://issues.apache.org/jira/browse/THRIFT-1659
             Project: Thrift
          Issue Type: Improvement
          Components: Node.js - Library
    Affects Versions: 0.8, 0.9
            Reporter: Eldon Stegall


By default, when java servers are created, they use the equivalent of the TBufferedTransport, which is the vanilla transport in java, but node.js clients use the TFramedTransport by default. In the interest of making compatibility between libraries the goal, the node.js library should use the TBufferedTransport by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1659) Bring nodejs default transport in line with Java default transport

Posted by "Eldon Stegall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eldon Stegall updated THRIFT-1659:
----------------------------------

    Patch Info: Patch Available
    
> Bring nodejs default transport in line with Java default transport
> ------------------------------------------------------------------
>
>                 Key: THRIFT-1659
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1659
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.8, 0.9
>            Reporter: Eldon Stegall
>         Attachments: thrift-change-nodejs-default-transport.patch
>
>
> By default, when java servers are created, they use the equivalent of the TBufferedTransport, which is the vanilla transport in java, but node.js clients use the TFramedTransport by default. In the interest of making compatibility between libraries the goal, the node.js library should use the TBufferedTransport by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1659) Bring nodejs default transport in line with Java default transport

Posted by "Eldon Stegall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eldon Stegall updated THRIFT-1659:
----------------------------------

    Description: By default, when java servers are created, they use the equivalent of the TBufferedTransport, which is the vanilla transport in java, but node.js clients use the TFramedTransport by default. In the interest of making compatibility between libraries by default the goal, the node.js library should use the TBufferedTransport by default.  (was: By default, when java servers are created, they use the equivalent of the TBufferedTransport, which is the vanilla transport in java, but node.js clients use the TFramedTransport by default. In the interest of making compatibility between libraries the goal, the node.js library should use the TBufferedTransport by default.)
    
> Bring nodejs default transport in line with Java default transport
> ------------------------------------------------------------------
>
>                 Key: THRIFT-1659
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1659
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.8, 0.9
>            Reporter: Eldon Stegall
>         Attachments: thrift-change-nodejs-default-transport.patch
>
>
> By default, when java servers are created, they use the equivalent of the TBufferedTransport, which is the vanilla transport in java, but node.js clients use the TFramedTransport by default. In the interest of making compatibility between libraries by default the goal, the node.js library should use the TBufferedTransport by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1659) Bring nodejs default transport in line with Java default transport

Posted by "Eldon Stegall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eldon Stegall updated THRIFT-1659:
----------------------------------

    Attachment: thrift-change-nodejs-default-transport.patch
    
> Bring nodejs default transport in line with Java default transport
> ------------------------------------------------------------------
>
>                 Key: THRIFT-1659
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1659
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.8, 0.9
>            Reporter: Eldon Stegall
>         Attachments: thrift-change-nodejs-default-transport.patch
>
>
> By default, when java servers are created, they use the equivalent of the TBufferedTransport, which is the vanilla transport in java, but node.js clients use the TFramedTransport by default. In the interest of making compatibility between libraries the goal, the node.js library should use the TBufferedTransport by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1659) Bring nodejs default transport in line with Java default transport

Posted by "Henrique Mendonca (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423000#comment-13423000 ] 

Henrique Mendonca commented on THRIFT-1659:
-------------------------------------------

+1, but it breaks the current tests:
make -C test/nodejs server &
make -C test/nodejs client

sorry i didn't have much time to find out the reason

Cheers,
Henrique
                
> Bring nodejs default transport in line with Java default transport
> ------------------------------------------------------------------
>
>                 Key: THRIFT-1659
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1659
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Node.js - Library
>    Affects Versions: 0.8, 0.9
>            Reporter: Eldon Stegall
>         Attachments: thrift-change-nodejs-default-transport.patch
>
>
> By default, when java servers are created, they use the equivalent of the TBufferedTransport, which is the vanilla transport in java, but node.js clients use the TFramedTransport by default. In the interest of making compatibility between libraries the goal, the node.js library should use the TBufferedTransport by default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira