[jira] [Commented] (IMPALA-8897) Fully qualify all paths on the webserver

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919166#comment-16919166 ] 

ASF subversion and git services commented on IMPALA-8897:
---------------------------------------------------------

Commit b7dfc18c59e831fa265d14ef4f7d26e33120b67f in impala's branch refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=b7dfc18 ]

IMPALA-8897: Update debug webui to help with Apache Knox rewrite rules

This patch adds the 'host:port' to all links on the webserver. This
will facilitate proxying connections to the debug webui through Knox
by allowing us to create rewrite rules that do the transform:

<a href="scheme://host:port/path">...</a>
=>
<a href="<knox-host>/topology/impalaui/path?scheme-scheme&host=host&port=port">...</a>

which allows us to have a single IMPALAUI Knox service that can proxy
connections to any impalad/statestored/catalogd webui in a cluster.

Note that this works because currently all of the links on Impala's
webui are within the same webserver (it would also be possible to add
links to other Impala daemon webuis within a cluster, eg. if we wanted
to add webui links on the /backends page). If we ever need to add
links to external pages, the Knox service definition will likely need
to be modified.

This patch also adds hidden fields to all forms for the scheme, host,
and port value, so that GET requests from forms will result in the
same form as the transformed url shown above.

Testing:
- Ran the webserver and manually clicked around on a bunch of links to
  ensure everything works as expected.
- Ran in a cluster and verified the new Knox service defintion works
  as intended with this change.
- Added a test that uses a regex to check for template files that
  don't conform to the requirements.

Change-Id: If1195709a0f21f39d9a1e484880a0c46c9967ed2
Reviewed-on: http://gerrit.cloudera.org:8080/14151
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Fully qualify all paths on the webserver
> ----------------------------------------
>
>                 Key: IMPALA-8897
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8897
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 3.4.0
>            Reporter: Thomas Tauber-Marshall
>            Assignee: Thomas Tauber-Marshall
>            Priority: Critical
>
> In order to support Knox proxying of the debug webui, we should fully qualify all links on our debug web ui with the host:port.
> This will allow us to create rewrite rules that do the transform:
> <a href="host:port/path">...</a>
> =>
> <a href="<knox-host>/topology/impalaui/path?host=host&port=port>...</a>
> One complication is preventing regressions when future links are added, since this is a difficult thing to test for



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org