You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Pierre Smits (JIRA)" <ji...@apache.org> on 2018/05/12 08:07:00 UTC

[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services

    [ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472972#comment-16472972 ] 

Pierre Smits commented on OFBIZ-10398:
--------------------------------------

The attached patch renames:
 * deletePartyContactMechPurposeIfExists to expirePartyContactMechPurposeIfExists
 * deletePartyContactMechPurpose to expirePartyContactMechPurpose

> Rename deletePartyContactMechPurpose* services
> ----------------------------------------------
>
>                 Key: OFBIZ-10398
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10398
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: order, party
>    Affects Versions: Trunk
>            Reporter: Pierre Smits
>            Assignee: Pierre Smits
>            Priority: Major
>         Attachments: OFBIZ-10398-rename.patch
>
>
> Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose are misnomers, as these functions don't delete records but expires those by setting the thruDate. The misnomers creates unnecessary confusion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)