You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/20 15:38:29 UTC
[GitHub] [airflow] mik-laj opened a new pull request #13194: Fix typs and minor simplification in TESTING.rst
mik-laj opened a new pull request #13194:
URL: https://github.com/apache/airflow/pull/13194
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13194: Fix typos and minor simplification in TESTING.rst
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13194:
URL: https://github.com/apache/airflow/pull/13194#issuecomment-749098771
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13194: Fix typos and minor simplification in TESTING.rst
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13194:
URL: https://github.com/apache/airflow/pull/13194#discussion_r546810933
##########
File path: TESTING.rst
##########
@@ -480,18 +481,18 @@ This installs airflow and enters
Running Tests with Kubernetes
=============================
-Airflow has tests that are run against real kubernetes cluster. We are using
+Airflow has tests that are run against real Kubernetes cluster. We are using
`Kind <https://kind.sigs.k8s.io/>`_ to create and run the cluster. We integrated the tools to start/stop/
deploy and run the cluster tests in our repository and into Breeze development environment.
-Configuration for the cluster is kept in ``./build/.kube/config`` file in your Airflow source repository and
+Configuration for the cluster is kept in ``./build/.kube/config`` file in your Airflow source repositor, and
Review comment:
Accepted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13194: Fix typos and minor simplification in TESTING.rst
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13194:
URL: https://github.com/apache/airflow/pull/13194#discussion_r546660737
##########
File path: TESTING.rst
##########
@@ -480,18 +481,18 @@ This installs airflow and enters
Running Tests with Kubernetes
=============================
-Airflow has tests that are run against real kubernetes cluster. We are using
+Airflow has tests that are run against real Kubernetes cluster. We are using
`Kind <https://kind.sigs.k8s.io/>`_ to create and run the cluster. We integrated the tools to start/stop/
deploy and run the cluster tests in our repository and into Breeze development environment.
-Configuration for the cluster is kept in ``./build/.kube/config`` file in your Airflow source repository and
+Configuration for the cluster is kept in ``./build/.kube/config`` file in your Airflow source repositor, and
Review comment:
```suggestion
Configuration for the cluster is kept in ``./build/.kube/config`` file in your Airflow source repository, and
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13194: Fix typos and minor simplification in TESTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13194:
URL: https://github.com/apache/airflow/pull/13194
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org