You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/01/26 08:40:53 UTC
Review Request 42786: Exposed the global 'help' process and added
getter functions to it.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
Repository: mesos
Description
-------
Previously, there was no way to extract the help strings from the help
process once they had been installed into it. The only way to get at
them was to visit the http endpoint they were associated with and pull
it from there.
This commit adds API calls to the process::Help class to get at these
strings more easily.
Diffs
-----
3rdparty/libprocess/include/process/help.hpp 2e76a6a5b1069abce879374a88cea65036873f1d
3rdparty/libprocess/include/process/process.hpp 1e4126f1082c24debd9d713b490d18f5ed83f0be
3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae
Diff: https://reviews.apache.org/r/42786/diff/
Testing
-------
Thanks,
Kevin Klues
Re: Review Request 42786: Exposed the global 'help' process and added
getter functions to it.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Jan. 26, 2016, 8:34 p.m., Neil Conway wrote:
> > 3rdparty/libprocess/include/process/help.hpp, line 111
> > <https://reviews.apache.org/r/42786/diff/1/?file=1221281#file1221281line111>
> >
> > Returning a raw pointer here is unfortunate. I wonder if it would be better to return the map by value (since performance is unlikely to matter for most callers), or else return a `shared_ptr`.
Also, since I don't imagine we want anyone modifying the helps through this pointer, perhaps it should be a `shared_ptr`-to-const.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/#review116432
-----------------------------------------------------------
On Jan. 26, 2016, 7:40 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42786/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:40 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, there was no way to extract the help strings from the help
> process once they had been installed into it. The only way to get at
> them was to visit the http endpoint they were associated with and pull
> it from there.
>
> This commit adds API calls to the process::Help class to get at these
> strings more easily.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 2e76a6a5b1069abce879374a88cea65036873f1d
> 3rdparty/libprocess/include/process/process.hpp 1e4126f1082c24debd9d713b490d18f5ed83f0be
> 3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae
>
> Diff: https://reviews.apache.org/r/42786/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42786: Exposed the global 'help' process and added
getter functions to it.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/#review116432
-----------------------------------------------------------
3rdparty/libprocess/include/process/help.hpp (line 111)
<https://reviews.apache.org/r/42786/#comment177446>
Returning a raw pointer here is unfortunate. I wonder if it would be better to return the map by value (since performance is unlikely to matter for most callers), or else return a `shared_ptr`.
3rdparty/libprocess/src/help.cpp (line 104)
<https://reviews.apache.org/r/42786/#comment177444>
Should just be `string`, not `std::string`.
- Neil Conway
On Jan. 26, 2016, 7:40 a.m., Kevin Klues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42786/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2016, 7:40 a.m.)
>
>
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, there was no way to extract the help strings from the help
> process once they had been installed into it. The only way to get at
> them was to visit the http endpoint they were associated with and pull
> it from there.
>
> This commit adds API calls to the process::Help class to get at these
> strings more easily.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/help.hpp 2e76a6a5b1069abce879374a88cea65036873f1d
> 3rdparty/libprocess/include/process/process.hpp 1e4126f1082c24debd9d713b490d18f5ed83f0be
> 3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae
>
> Diff: https://reviews.apache.org/r/42786/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Klues
>
>
Re: Review Request 42786: Exposed the global 'help' process and added
getter functions to it.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 10:30 p.m.)
Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
Changes
-------
Reversed order of patches between adding suppport for remove() and exposing Help externally with get() functions.
Bugs: MESOS-4552
https://issues.apache.org/jira/browse/MESOS-4552
Repository: mesos
Description
-------
Previously, there was no way to extract the help strings from the help
process once they had been installed into it. The only way to get at
them was to visit the http endpoint they were associated with and pull
it from there.
This commit adds API calls to the process::Help class to get at these
strings more easily.
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp 2e76a6a5b1069abce879374a88cea65036873f1d
3rdparty/libprocess/include/process/process.hpp 1e4126f1082c24debd9d713b490d18f5ed83f0be
3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae
Diff: https://reviews.apache.org/r/42786/diff/
Testing
-------
Thanks,
Kevin Klues
Re: Review Request 42786: Exposed the global 'help' process and added
getter functions to it.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 10:24 a.m.)
Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
Bugs: MESOS-4552
https://issues.apache.org/jira/browse/MESOS-4552
Repository: mesos
Description
-------
Previously, there was no way to extract the help strings from the help
process once they had been installed into it. The only way to get at
them was to visit the http endpoint they were associated with and pull
it from there.
This commit adds API calls to the process::Help class to get at these
strings more easily.
Diffs
-----
3rdparty/libprocess/include/process/help.hpp 2e76a6a5b1069abce879374a88cea65036873f1d
3rdparty/libprocess/include/process/process.hpp 1e4126f1082c24debd9d713b490d18f5ed83f0be
3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae
Diff: https://reviews.apache.org/r/42786/diff/
Testing
-------
Thanks,
Kevin Klues
Re: Review Request 42786: Exposed the global 'help' process and added
getter functions to it.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 10:13 a.m.)
Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
Changes
-------
Addressed comments. Aftr thinking more about it a bit more, copying the map actually makes the most sense.
Repository: mesos
Description
-------
Previously, there was no way to extract the help strings from the help
process once they had been installed into it. The only way to get at
them was to visit the http endpoint they were associated with and pull
it from there.
This commit adds API calls to the process::Help class to get at these
strings more easily.
Diffs (updated)
-----
3rdparty/libprocess/include/process/help.hpp 2e76a6a5b1069abce879374a88cea65036873f1d
3rdparty/libprocess/include/process/process.hpp 1e4126f1082c24debd9d713b490d18f5ed83f0be
3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae
Diff: https://reviews.apache.org/r/42786/diff/
Testing
-------
Thanks,
Kevin Klues