You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2023/05/31 21:10:27 UTC

[GitHub] [flink-connector-opensearch] snuyanzin commented on pull request #24: [FLINK-31856] Add support for Opensearch Connector REST client customization

snuyanzin commented on PR #24:
URL: https://github.com/apache/flink-connector-opensearch/pull/24#issuecomment-1570961803

   Thanks @reta 
   In general it looks ok
   
   I have a minor comment
   
   \+ in jira it was mentioned a case 
   >We are currently using the using the OpensearchSink in [connector/opensearch/sink/OpensearchSink.java](https://github.com/apache/flink-connector-opensearch/blob/main/flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchSink.java) and need to be able to authenticate/authorise with Opensearch using OAuth2 and therefore need to be able to pass a bearer token to the bulk index calls.
   
   It would be great to add it as ITTest, WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org