[jira] [Commented] (AMBARI-7870) ShellCommandUtil.Results class should be public, not package private

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177282#comment-14177282 ] 

Hadoop QA commented on AMBARI-7870:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12675882/AMBARI-7870.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

      {color:red}-1 javac{color}.  The applied patch generated 39 javac compiler warnings (more than the trunk's current 38 warnings).

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-server.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/268//testReport/
Javac warnings: https://builds.apache.org/job/Ambari-trunk-test-patch/268//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/268//console

This message is automatically generated.

> ShellCommandUtil.Results class should be public, not package private
> --------------------------------------------------------------------
>
>                 Key: AMBARI-7870
>                 URL: https://issues.apache.org/jira/browse/AMBARI-7870
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-server
>    Affects Versions: 1.7.0
>            Reporter: Robert Levas
>            Assignee: Robert Levas
>            Priority: Minor
>              Labels: utils
>             Fix For: 2.0.0
>
>         Attachments: AMBARI-7870.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> {{ShellCommandUtil.Results}} class should be _public_, _not package_ private. Because it is _package private_, any {{ShellCommandUtil}} public methods returning a {{ShellCommandUtil.Results}} is basically unusable outside of the {{org.apache.ambari.server.utils}} package.
> Solution:  Make {{ShellCommandUtil.Results}} and its methods explicitly _public_



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)