You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/05/25 22:48:53 UTC

Review Request 59582: Made the executor driver drop some messages when not connected.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59582/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.


Bugs: MESOS-7542
    https://issues.apache.org/jira/browse/MESOS-7542


Repository: mesos


Description
-------

This patch updates the executor driver to drop RunTaskMessages,
FrameworkMessages, and StatusUpdateAcknowledgements when it is
not connected to the agent. This facilitates executor reconnect
retry logic which is being added to the agent.


Diffs
-----

  src/exec/exec.cpp f36e3707d8804b63ec1ca4e7f16728210f0029de 


Diff: https://reviews.apache.org/r/59582/diff/1/


Testing
-------

Testing details can be found at the end of this chain.


Thanks,

Greg Mann


Re: Review Request 59582: Made the executor driver drop some messages when not connected.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59582/#review176193
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On May 25, 2017, 10:48 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59582/
> -----------------------------------------------------------
> 
> (Updated May 25, 2017, 10:48 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-7542
>     https://issues.apache.org/jira/browse/MESOS-7542
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the executor driver to drop RunTaskMessages,
> FrameworkMessages, and StatusUpdateAcknowledgements when it is
> not connected to the agent. This facilitates executor reconnect
> retry logic which is being added to the agent.
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp f36e3707d8804b63ec1ca4e7f16728210f0029de 
> 
> 
> Diff: https://reviews.apache.org/r/59582/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>