You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2013/01/18 23:20:12 UTC
[jira] [Resolved] (HADOOP-9226) IOUtils.CloseQuietly() to intercept
RuntimeExceptions as well as IOExceptions
[ https://issues.apache.org/jira/browse/HADOOP-9226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Loughran resolved HADOOP-9226.
------------------------------------
Resolution: Invalid
Release Note: That comment about {{cleanup}} made me go and look at {{IOUtils}} more closely -it turns out that it's Commons-IO that I'd mistakenly import. Their {{closeQuietly()}} doesn't handle exceptions other than IOE -but {{cleanup}} does. Marking as invalid.
> IOUtils.CloseQuietly() to intercept RuntimeExceptions as well as IOExceptions
> -----------------------------------------------------------------------------
>
> Key: HADOOP-9226
> URL: https://issues.apache.org/jira/browse/HADOOP-9226
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 1.1.1, 2.0.3-alpha
> Reporter: Steve Loughran
> Priority: Minor
>
> A stack trace of mine shows that call of {{IOException.closeQuietly()}} forwarded an NPE up from the JetS3t library's {{close()}} method. We *may* want to have the various {{CloseQuietly()}} method intercept and log such things too, on the assumption that the goal of those close operations is to downgrade all close-time exceptions into log events.
> If people agree that's what we want, I'll do the patch & test
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira