[GitHub] [madlib] kaknikhil commented on a change in pull request #491: DL: Fix disk issue by using truncate guc

[GitBox <gi...@apache.org>]

kaknikhil commented on a change in pull request #491:  DL: Fix disk issue by using truncate guc 
URL: https://github.com/apache/madlib/pull/491#discussion_r396835254
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/test/madlib_keras_model_selection.sql_in
 ##########
 @@ -210,6 +210,11 @@ SELECT assert(
         'Keras Fit Multiple Output Summary Validation failed when user passes in 1-hot encoded label vector. Actual:' || __to_char(summary))
 FROM (SELECT * FROM iris_multiple_model_summary) summary;
 
+-- Test the output table created are all persistent(not unlogged)
+SELECT assert(MADLIB_SCHEMA.is_table_unlogged('iris_multiple_model') = false, 'Model output table is unlogged');
 
 Review comment:
   we should add the same test for warm start as well

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services