You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by be...@apache.org on 2023/02/06 15:15:08 UTC

[lucene] branch main updated: Fix TestFeatureField#testBasicsNonScoringCase test (#12130)

This is an automated email from the ASF dual-hosted git repository.

benwtrent pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/lucene.git


The following commit(s) were added to refs/heads/main by this push:
     new c2bef381d1e Fix TestFeatureField#testBasicsNonScoringCase test (#12130)
c2bef381d1e is described below

commit c2bef381d1ee98fd2589e565654e8614c37e6cec
Author: Benjamin Trent <be...@gmail.com>
AuthorDate: Mon Feb 6 10:15:00 2023 -0500

    Fix TestFeatureField#testBasicsNonScoringCase test (#12130)
    
    Sometimes the random search lucene test searcher will wrap the reader. Consequently, we need to make sure to use the reader provided by the test IndexSearcher or the reader may be different between creating the weight with the searcher vs. accessing the leaf context for the scorer.
---
 lucene/core/src/test/org/apache/lucene/document/TestFeatureField.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lucene/core/src/test/org/apache/lucene/document/TestFeatureField.java b/lucene/core/src/test/org/apache/lucene/document/TestFeatureField.java
index 3ec9bc4b3da..2b1e4ef8875 100644
--- a/lucene/core/src/test/org/apache/lucene/document/TestFeatureField.java
+++ b/lucene/core/src/test/org/apache/lucene/document/TestFeatureField.java
@@ -84,7 +84,7 @@ public class TestFeatureField extends LuceneTestCase {
     writer.close();
 
     IndexSearcher searcher = LuceneTestCase.newSearcher(reader);
-    LeafReaderContext context = reader.leaves().get(0);
+    LeafReaderContext context = searcher.getIndexReader().leaves().get(0);
 
     Query q = FeatureField.newLogQuery("features", "pagerank", 3f, 4.5f);
     Weight w = q.createWeight(searcher, ScoreMode.TOP_SCORES, 2);
@@ -408,7 +408,7 @@ public class TestFeatureField extends LuceneTestCase {
       }
 
       IndexSearcher searcher = LuceneTestCase.newSearcher(reader);
-      LeafReaderContext context = reader.leaves().get(0);
+      LeafReaderContext context = searcher.getIndexReader().leaves().get(0);
 
       for (Query q :
           List.of(