You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/30 23:26:28 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4180: Minor
improvements as encountered while studying replica groups
codecov-io commented on issue #4180: Minor improvements as encountered while studying replica groups
URL: https://github.com/apache/incubator-pinot/pull/4180#issuecomment-488150706
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4180?src=pr&el=h1) Report
> Merging [#4180](https://codecov.io/gh/apache/incubator-pinot/pull/4180?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/b4c9bdc6fb4f741d1865077fbf6d2ef62027b430?src=pr&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `92.85%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4180?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4180 +/- ##
============================================
- Coverage 67.26% 67.24% -0.03%
Complexity 20 20
============================================
Files 1037 1037
Lines 51455 51445 -10
Branches 7201 7197 -4
============================================
- Hits 34612 34592 -20
- Misses 14465 14474 +9
- Partials 2378 2379 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4180?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/pinot/common/partition/PartitionAssignment.java](https://codecov.io/gh/apache/incubator-pinot/pull/4180/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcGFydGl0aW9uL1BhcnRpdGlvbkFzc2lnbm1lbnQuamF2YQ==) | `66.66% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...not/broker/routing/RoutingTableBuilderFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4180/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9Sb3V0aW5nVGFibGVCdWlsZGVyRmFjdG9yeS5qYXZh) | `41.66% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...mon/partition/ReplicaGroupPartitionAssignment.java](https://codecov.io/gh/apache/incubator-pinot/pull/4180/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcGFydGl0aW9uL1JlcGxpY2FHcm91cFBhcnRpdGlvbkFzc2lnbm1lbnQuamF2YQ==) | `93.1% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/pinot/common/utils/LLCUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4180/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvTExDVXRpbHMuamF2YQ==) | `75% <100%> (-3.58%)` | `0 <0> (ø)` | |
| [...lder/PartitionAwareOfflineRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4180/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL1BhcnRpdGlvbkF3YXJlT2ZmbGluZVJvdXRpbmdUYWJsZUJ1aWxkZXIuamF2YQ==) | `71.83% <100%> (-0.78%)` | `0 <0> (ø)` | |
| [...ing/builder/GeneratorBasedRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4180/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9idWlsZGVyL0dlbmVyYXRvckJhc2VkUm91dGluZ1RhYmxlQnVpbGRlci5qYXZh) | `100% <100%> (+3.48%)` | `0 <0> (ø)` | :arrow_down: |
| [...ebalance/ReplicaGroupRebalanceSegmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4180/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYmFsYW5jZS9SZXBsaWNhR3JvdXBSZWJhbGFuY2VTZWdtZW50U3RyYXRlZ3kuamF2YQ==) | `82.25% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...harding/ReplicaGroupSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4180/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3NoYXJkaW5nL1JlcGxpY2FHcm91cFNlZ21lbnRBc3NpZ25tZW50U3RyYXRlZ3kuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4180/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `75% <0%> (-25%)` | `0% <0%> (ø)` | |
| [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4180/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `71.42% <0%> (-12.99%)` | `0% <0%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/incubator-pinot/pull/4180/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4180?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4180?src=pr&el=footer). Last update [b4c9bdc...7e32586](https://codecov.io/gh/apache/incubator-pinot/pull/4180?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org