Re: [PR] [fix][broker] Fix starting function worker with tls error [pulsar]

["merlimat (via GitHub)" <gi...@apache.org>]

merlimat commented on PR #21221:
URL: https://github.com/apache/pulsar/pull/21221#issuecomment-6353957849

   Thanks @Technoboy-. The NPE in the description comes from `KeyManagerProxy`, which no longer exists on master since the PIP-478 TLS rewrite. TLS-only URL selection for the embedded worker is already handled (`PulsarService#startWorkerService`), and `PulsarFunctionTlsTest` covers a TLS-only mTLS worker. The remaining gap is narrower: the embedded worker doesn't inherit `brokerClientKeyFilePath`/`brokerClientCertificateFilePath`, and it gates the auth plugin on `authenticationEnabled`. That's better done as a small new PR than by rebasing this one, which also reuses the broker's server cert as the client cert and overrides `brokerClientAuthenticationEnabled`. Closing for now; please reopen or ping me if you see this on a current release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org