You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2016/01/03 10:50:45 UTC
Re: Review Request 41380: Added repeated vip field to DiscoveryInfo
and an instance_port field to Port
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41380/#review112441
-----------------------------------------------------------
Ship it!
Looks good. I'm cleaning up the comments before I commit.
include/mesos/mesos.proto (lines 1557 - 1560)
<https://reviews.apache.org/r/41380/#comment172914>
Re-wrap.
I also removed some fluff so this fits on 3 lines: "This field represents", "potentially", and s/for instance,/e.g./
```
// The backend port on which the task is running. This could be different than
// the `number` field (1), e.g. when an agent achieves network isolation
// between containers using port (layer 4) segregation.
```
include/mesos/mesos.proto (lines 1577 - 1579)
<https://reviews.apache.org/r/41380/#comment172913>
TODOs don't use a space before the `(userid)`.
Let's add the missing field as a comment, so we can easily see what we're omitting.
Also reworded to emphasize the skipped tag `1` rather than ip_address using tag `2`, and binary compatibility over backwards compatibility:
```
// TODO(asridharan): We skip tag number 1 in case we later want to be binary
// compatible with `NetworkInfo.IPAddress`. See MESOS-4243 for more details.
// optional Protocol protocol = 1;
```
- Adam B
On Dec. 28, 2015, 5:10 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41380/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2015, 5:10 p.m.)
>
>
> Review request for mesos, Adam B and Anand Mazumdar.
>
>
> Bugs: MESOS-4114
> https://issues.apache.org/jira/browse/MESOS-4114
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added repeated vip field to DiscoveryInfo and an instance_port field to Port
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6
> include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8
>
> Diff: https://reviews.apache.org/r/41380/diff/
>
>
> Testing
> -------
>
> make check, and make
>
>
> Thanks,
>
> Avinash sridharan
>
>