DO NOT REPLY [Bug 12115] New: - [PATCH]NPE in AbstractCachingProcessingPipeline.java

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12115>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12115

[PATCH]NPE in AbstractCachingProcessingPipeline.java

           Summary: [PATCH]NPE in AbstractCachingProcessingPipeline.java
           Product: Cocoon 2
           Version: Current CVS
          Platform: All
        OS/Version: Windows NT/2K
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: core
        AssignedTo: cocoon-dev@xml.apache.org
        ReportedBy: robert@leftwich.info


It is possible for the variable cachedPipelineKey to be null at line 554 of 
AbstractCachingProcessingPipeline.java. This can cause a NPE. The patch is to 
add a null check to line 554 as follows:

  if (null != cachedPipelineKey && (i > 0 && i > cachedPipelineKey.size())) {

This patch makes the assumption that it is valid for the else part of this 
statement to be run when cachedPipelineKey is null. I do not have sufficient 
understanding of the caching requirements to verify this assumption. Note that 
the statements in the else part are as follows:

  this.pipelineCacheKey = null;
  this.pipelineValidityObjects = null;
  len = 0;

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org