You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/04/27 15:21:41 UTC
[PR] docs: rename SQL File Tests to Comet SQL Tests [datafusion-comet]
andygrove opened a new pull request, #4108:
URL: https://github.com/apache/datafusion-comet/pull/4108
## Which issue does this PR close?
Closes #.
## Rationale for this change
The contributor guide currently has a page called "SQL File Tests" that documents `CometSqlFileTestSuite`, our preferred framework for adding expression and operator test coverage via `.sql` files. The name "SQL File Tests" is generic and easily confused with the unrelated "Spark SQL Tests" and "Iceberg Spark Tests" pages. Renaming to "Comet SQL Tests" makes the naming consistent with how we already refer to other Comet-specific testing artifacts and groups it visually with its sibling pages in the index.
For symmetry, this PR also renames inline references to Scala-based Comet tests as "Comet Scala Tests" so the two test categories are named consistently throughout the docs and skills.
## What changes are included in this PR?
- Rename the toctree entry from "SQL File Tests" to "Comet SQL Tests" and move it directly before "Spark SQL Tests" in `docs/source/contributor-guide/index.md`.
- Rename the page heading in `sql-file-tests.md`.
- Update `development.md` and `adding_a_new_expression.md` to use "Comet SQL Tests" and "Comet Scala Tests" consistently.
- Update the `audit-comet-expression` and `review-comet-pr` skills under `.claude/skills/` to use the new terminology.
No code or test behavior is changed; the file path `sql-file-tests.md` is preserved so existing links continue to resolve.
## How are these changes tested?
Documentation-only change. Verified by inspection that all renamed references resolve correctly within the contributor guide and that no stale "SQL File Tests" or generic "Scala tests" wording remains in the touched files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] docs: rename SQL File Tests to Comet SQL Tests [datafusion-comet]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #4108:
URL: https://github.com/apache/datafusion-comet/pull/4108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org