You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Sean Mackrory (JIRA)" <ji...@apache.org> on 2017/02/15 18:35:41 UTC
[jira] [Updated] (HADOOP-13736) Change PathMetadata to hold
S3AFileStatus instead of FileStatus.
[ https://issues.apache.org/jira/browse/HADOOP-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Mackrory updated HADOOP-13736:
-----------------------------------
Attachment: HADOOP-13736-HADOOP-13345.006.patch
This is almost identical to the .005. patch, just resolving a few minor conflicts. All tests pass (minus a few that will be addressed by other outstanding patches under HADOOP-13345).
I'd like to get this in soon as I often (but not always, wierdly) have a bunch of tests fail because an assertion that a FileStatus is an instance of S3AFileStatus, and it would be good to clean this up. This will mean that several patches I've submitted need to rebased, but I think that will be true for a long time, so I think we should just take the hit.
I know [~fabbri] may have some work affected, and possibly [~stevel@apache.org]. Any concerns, guys?
> Change PathMetadata to hold S3AFileStatus instead of FileStatus.
> ----------------------------------------------------------------
>
> Key: HADOOP-13736
> URL: https://issues.apache.org/jira/browse/HADOOP-13736
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Attachments: HADOOP-13736.000.patch, HADOOP-13736-HADOOP-13345.000.patch, HADOOP-13736-HADOOP-13345.001.patch, HADOOP-13736-HADOOP-13345.002.patch, HADOOP-13736-HADOOP-13345.003.patch, HADOOP-13736-HADOOP-13345.004.patch, HADOOP-13736-HADOOP-13345.005.patch, HADOOP-13736-HADOOP-13345.006.patch, HADOOP-13736.wip-01.patch
>
>
> {{S3AFileStatus}} is implemented differently with {{FileStatus}}, for instance {{S3AFileStatus#isEmptyDirectory()}} is not implemented in {{FileStatus()}}. And {{access_time}}, {{block_replication}}, {{owner}}, {{group}} and a few other fields are not meaningful in {{S3AFileStatus}}.
> So in the scope of {{S3guard}}, it should use {{S3AFileStatus}} in instead of {{FileStatus}} in {{PathMetadaa}} to avoid casting the types back and forth in S3A.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org