[GitHub] [arrow] ArianaVillegas commented on pull request #13334: ARROW-14314: [C++] Sorting dictionary array not implemented

[GitBox <gi...@apache.org>]

ArianaVillegas commented on PR #13334:
URL: https://github.com/apache/arrow/pull/13334#issuecomment-1174464571

   @pitrou do you know why the output of `operation()` on sorting is `NullPartitionResult` when the indices sorted array references are `indices_begin` and `indices_begin`? Why don't just return and Status instead? 
   
   ```
   <NullPartitionResult> operator()(uint64_t* indices_begin, uint64_t* indices_end,
                                            const Array& array, int64_t offset,
                                            const ArraySortOptions& options)
   ```
   
   And, if NullPartitionResult is needed, why it is not assigned on [ArraySortIndices](https://github.com/ArianaVillegas/arrow/blob/b4b0bd4a96cb37628f4a6742800bbddf7f26deaa/cpp/src/arrow/compute/kernels/vector_array_sort.cc#L525)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org