You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2015/02/09 12:43:23 UTC
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/378
TAJO-1298: Improve the printing message after an execution of an index creation statement
In this issue, I improved the printing message after an index creation.
In addition, I changed the writing process of ```create index``` query to exploit the result staging feature. Instead of directly writing the results in the output directory, Tajo writes them in the staging the results and moves them to the final output directory on the successful query execution.
The following is an example of the improved message.
```
default> create index l_orderkey_idx on lineitem (l_orderkey);
Progress: 0%, response time: 1.169 sec
Progress: 0%, response time: 1.17 sec
...
Progress: 83%, response time: 17.446 sec
Progress: 100%, response time: 17.758 sec
(0 rows, 17.758 sec, 70.4 MiB inserted)
default>
```
As shown in this example, the number of inserted bytes represents the total index size.
However, the number of rows is 0. I think this is right because index files contain the binary information about the index structure, so the number of inserted rows cannot be computed.
Alternatively, we can show the number of rows of source table instead of the inserted number of rows.
In this case, I'm concerning the inconsistency of the printing messages.
What do you think?
Or, any other good idea?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jihoonson/tajo-2 TAJO-1298
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/378.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #378
----
commit dafda3964dfd8f492b61506adf0e06f8a50dd28e
Author: Jihoon Son <ji...@apache.org>
Date: 2015-02-03T09:44:00Z
TAJO-1298
commit 2de9f20fc553b6c227d898d156cca85dbcf6f151
Author: Jihoon Son <ji...@apache.org>
Date: 2015-02-06T08:36:35Z
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1298
commit e981ff419172f9a368304e16738a7e545cdb0b25
Author: Jihoon Son <ji...@apache.org>
Date: 2015-02-09T05:38:27Z
TAJO-1298
commit edf464783401264e854e9356de658ec4e4b3ecec
Author: Jihoon Son <ji...@apache.org>
Date: 2015-02-09T11:24:57Z
TAJO-1298
commit aa45f842146eb81c271a60d6fba4c97d61dc4a85
Author: Jihoon Son <ji...@apache.org>
Date: 2015-02-09T11:26:46Z
TAJO-1298
commit 18824fe21beff7f677485750f932057a69f32613
Author: Jihoon Son <ji...@apache.org>
Date: 2015-02-09T11:29:05Z
Merge branch 'index_support' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-1298
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/378#issuecomment-76522744
How about 'Index written'? I think that just 'written' may look 'table written' or 'data written'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/378#issuecomment-77972626
Could you trigger the unit test?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/378#issuecomment-75424027
I changed the message according to @hyunsik's comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/378#issuecomment-114734705
@hyunsik, this patch is finally ready for review. Please review when you have sufficient free slots.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson closed the pull request at:
https://github.com/apache/tajo/pull/378
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/378#issuecomment-75350750
```
Progress: 100%, response time: 17.758 sec
(0 rows, 17.758 sec, 70.4 MiB inserted)
default>
```
It does look the result about index creation because the message is the same to general CTASs. Especially, it would be better if the word 'inserted' is changed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/378#issuecomment-76587982
+1
The change looks good to me. This patch seems to be ready to be committed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/378#issuecomment-78022444
@hyunsik, I made some changes in GlobalEngine, especially DDL execution part. They cause some problems with HBaseStorqageManager. I already created an issue (https://issues.apache.org/jira/browse/TAJO-1373). After resolving that issue, I'll trigger again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/378#issuecomment-76593141
@hyunsik, thanks for your comment.
Actually, I have just updated my patch according to my suggestion.
Please review again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/378#issuecomment-75352984
Thanks for your comment.
I'll change 'inserted' to 'written'.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/378#issuecomment-73628391
I fixed the test failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1298: Improve the printing message after a...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/378#issuecomment-76563796
Actually, I used 'written' as the meaning of 'data written'.
But, as you said, it would be better if users can see what type of query is finished.
So, I'd like to suggest adding the finished query type as follows.
```
Progress: 100%, response time: 17.758 sec
(0 rows, 17.758 sec, 70.4 MiB written)
CREATE INDEX OK
default>
```
We also can show this kind of message after ```CREATE TABLE``` or ```INSERT``` statements.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---