You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bs...@apache.org on 2017/08/30 20:52:58 UTC
geode git commit: GEODE-3249 Validate internal client/server messages
Repository: geode
Updated Branches:
refs/heads/develop 17662cd46 -> f2492bf0a
GEODE-3249 Validate internal client/server messages
The addition of USER_CREDENTIAL_MESSAGE in ServerConnection.isInternalMessage
caused problems for the c++ client. This message class does require
credentials and shouldn't be included in the set of internal messages.
Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/f2492bf0
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/f2492bf0
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/f2492bf0
Branch: refs/heads/develop
Commit: f2492bf0abdc662cc080f1e2c0f17257e05604a3
Parents: 17662cd
Author: Bruce Schuchardt <bs...@pivotal.io>
Authored: Wed Aug 30 13:50:48 2017 -0700
Committer: Bruce Schuchardt <bs...@pivotal.io>
Committed: Wed Aug 30 13:52:50 2017 -0700
----------------------------------------------------------------------
.../apache/geode/internal/cache/tier/sockets/ServerConnection.java | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/geode/blob/f2492bf0/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
----------------------------------------------------------------------
diff --git a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
index 6f56e85..1925898 100644
--- a/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
+++ b/geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
@@ -1097,7 +1097,6 @@ public abstract class ServerConnection implements Runnable {
public boolean isInternalMessage(Message message, boolean allowOldInternalMessages) {
int messageType = message.getMessageType();
boolean isInternalMessage = messageType == MessageType.PING
- || messageType == MessageType.USER_CREDENTIAL_MESSAGE
|| messageType == MessageType.REQUEST_EVENT_VALUE || messageType == MessageType.MAKE_PRIMARY
|| messageType == MessageType.REMOVE_USER_AUTH || messageType == MessageType.CLIENT_READY
|| messageType == MessageType.SIZE || messageType == MessageType.TX_FAILOVER