[GitHub] [druid] jihoonson commented on a change in pull request #10363: fix injection failure of StorageLocationSelectorStrategy objects

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #10363:
URL: https://github.com/apache/druid/pull/10363#discussion_r489986586



##########
File path: server/src/main/java/org/apache/druid/segment/loading/SegmentLoaderConfig.java
##########
@@ -54,9 +54,6 @@
   @JsonProperty("numBootstrapThreads")
   private Integer numBootstrapThreads = null;
 
-  @JsonProperty("locationSelectorStrategy")
-  private StorageLocationSelectorStrategy locationSelectorStrategy;

Review comment:
       I think the previous implementation is better since you can use the configuration name `druid.segmentCache.locationSelectorStrategy` without `type`. Is there a reason that `locationSelectorStrategy` cannot be here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org