You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2021/09/20 08:31:56 UTC
Review Request 73592: RANGER-3420: resource matcher updated to support
quoted resource names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73592/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
Bugs: RANGER-3420
https://issues.apache.org/jira/browse/RANGER-3420
Repository: ranger
Description
-------
updated resource matcher with following options, to support quoted identifiers
- quotedCaseSensitive
- quoteChars
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 475453966
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/ResourceMatcher.java 35856a96e
agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcher.java 8ea71057a
agents-common/src/test/resources/resourcematcher/test_defaultpolicyresourcematcher_quoted.json PRE-CREATION
Diff: https://reviews.apache.org/r/73592/diff/1/
Testing
-------
- added new unit tests to validate the enhancements
- verified that existing unit tests pass successfully
Thanks,
Madhan Neethiraj
Re: Review Request 73592: RANGER-3420: resource matcher updated to
support quoted resource names
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73592/#review223506
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Sept. 21, 2021, 2:07 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73592/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2021, 2:07 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-3420
> https://issues.apache.org/jira/browse/RANGER-3420
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated resource matcher with following options, to support quoted identifiers
> - quotedCaseSensitive
> - quoteChars
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 475453966
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/ResourceMatcher.java 35856a96e
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcher.java 8ea71057a
> agents-common/src/test/resources/resourcematcher/test_defaultpolicyresourcematcher_quoted.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/73592/diff/2/
>
>
> Testing
> -------
>
> - added new unit tests to validate the enhancements
> - verified that existing unit tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 73592: RANGER-3420: resource matcher updated to
support quoted resource names
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73592/
-----------------------------------------------------------
(Updated Sept. 21, 2021, 2:07 a.m.)
Review request for ranger, Ankita Sinha, Don Bosco Durai, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
Changes
-------
addressed review comments
Bugs: RANGER-3420
https://issues.apache.org/jira/browse/RANGER-3420
Repository: ranger
Description
-------
updated resource matcher with following options, to support quoted identifiers
- quotedCaseSensitive
- quoteChars
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 475453966
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/ResourceMatcher.java 35856a96e
agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcher.java 8ea71057a
agents-common/src/test/resources/resourcematcher/test_defaultpolicyresourcematcher_quoted.json PRE-CREATION
Diff: https://reviews.apache.org/r/73592/diff/2/
Changes: https://reviews.apache.org/r/73592/diff/1-2/
Testing
-------
- added new unit tests to validate the enhancements
- verified that existing unit tests pass successfully
Thanks,
Madhan Neethiraj
Re: Review Request 73592: RANGER-3420: resource matcher updated to
support quoted resource names
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73592/#review223504
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java
Line 87 (original), 91 (patched)
<https://reviews.apache.org/r/73592/#comment312583>
Please consider setting optQuotedCaseSensitive thus:
optQuotedCaseSensitive = getOptionQuotedCaseSensitive(options);
It appears that this will not change any semantics of new code using value of optQuotedCaseSensitive member variable.
- Abhay Kulkarni
On Sept. 20, 2021, 8:31 a.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73592/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2021, 8:31 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
>
>
> Bugs: RANGER-3420
> https://issues.apache.org/jira/browse/RANGER-3420
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated resource matcher with following options, to support quoted identifiers
> - quotedCaseSensitive
> - quoteChars
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerAbstractResourceMatcher.java 475453966
> agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/ResourceMatcher.java 35856a96e
> agents-common/src/test/java/org/apache/ranger/plugin/resourcematcher/TestDefaultPolicyResourceMatcher.java 8ea71057a
> agents-common/src/test/resources/resourcematcher/test_defaultpolicyresourcematcher_quoted.json PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/73592/diff/1/
>
>
> Testing
> -------
>
> - added new unit tests to validate the enhancements
> - verified that existing unit tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>